Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add retry to assert containers do not exist for compose down #73

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

ningziwen
Copy link
Member

runfinch/finch#460

  • [ X ] I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ningziwen ningziwen requested a review from monirul June 26, 2023 06:02
Signed-off-by: Ziwen Ning <ningziwe@amazon.com>
Copy link
Contributor

@monirul monirul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Added few comments.

@ningziwen ningziwen merged commit 88f732f into runfinch:main Jun 26, 2023
@ningziwen ningziwen deleted the compose branch June 26, 2023 18:46
ginglis13 pushed a commit that referenced this pull request Jul 13, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.7.1](v0.7.0...v0.7.1)
(2023-06-27)


### Bug Fixes

* add retry to assert containers do not exist for compose down
([#73](#73))
([88f732f](88f732f))


### Build System or External Dependencies

* **deps:** bump github.com/onsi/ginkgo/v2 from 2.10.0 to 2.11.0
([#71](#71))
([45e9414](45e9414))
* **deps:** bump github.com/onsi/ginkgo/v2 from 2.9.5 to 2.10.0
([#69](#69))
([a6ad55d](a6ad55d))
* **deps:** bump github.com/onsi/gomega from 1.27.7 to 1.27.8
([#68](#68))
([6c72750](6c72750))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants