Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Hunt down and remove all unwrap #176

Open
NYBACHOK opened this issue Jul 12, 2024 · 2 comments · Fixed by #258
Open

[FEATURE]: Hunt down and remove all unwrap #176

NYBACHOK opened this issue Jul 12, 2024 · 2 comments · Fixed by #258
Labels
enhancement New feature or request priority

Comments

@NYBACHOK
Copy link
Collaborator

Feature description

We have unwraps in our code. They should be removed

@NYBACHOK NYBACHOK added the enhancement New feature or request label Jul 12, 2024
@dmvict
Copy link
Collaborator

dmvict commented Jul 12, 2024

I guess that here we have to apply some convention. Something like:

  • unwrap's should be replaced to expect's if we have reasons to unwrap without handling the error
  • unwrap's should be replaced to panic's with proper error messages for the other cases
  • if it is possible, change signature of a routine to handle error properly

Let's discuss these points. I'm trying to make the issue clear and more concrete.

@NYBACHOK NYBACHOK linked a pull request Sep 5, 2024 that will close this issue
@NYBACHOK
Copy link
Collaborator Author

Remove most of the easy ones, but there are still some which require more time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants