-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reword compatibility warnings and improve README to be more user-friendly #77
Comments
Thanks for the suggestion. I agree that the message could be improved, however there is a limited amount of space for the message. Unfortunately, your suggestion is a bit too long as it wouldn't fit on screen without using multiple lines. Changing the existing message is easy, and it can be found here:
I'd prefer if the new message has a comparable size, so it could fit in a single line. Do you have any ideas for a message that would be shorter? For example, what do you think of:
|
I like your suggestion. In fact I like it much better than what I came up. Your message is quite short, which increases the chance of users actually reading it while while still maintaining a nice balance between informing the user about potential conflicts without being worded too definitively. |
Sorry, I've been quite busy lately. Planning to tackle this soon, hopefully this week. In addition, someone suggested I update the intro to the Readme to make it easier to understand why libWrapper is useful, specifically:
These need a bit of proofreading/clean up, but should probably be mentioned at the start of the readme. |
Resolved in v1.12.13.0. Closing. |
Whenever two modules hook the same function, libwrapper emits a warning to the user that the two modules are potentially incompatible. There is a user base of foundry, that doesn't read this warning as what it is - a hint to check if the modules work together properly - but rather as an error message that informs them that there are in fact problems. Some of these users then go to the repositories of the respective modules and open an issue reporting a module compatibility. Those bug reports usually end up being false positives, so every time a user opens an issue like this the author of that module wastes some of their module development time by investigating an issue that doesn't exist.
Additionally, I suspect that for every user that's getting in touch with the community to ask about that error, there are probably 10 users who will never reach out, but who will uninstall one of the two modules to avoid breakage, not knowing that the modules are fully compatible.
To solve this, I'd like to ask for the warning message to be reworded in a way that makes the fact that there might not be any issues after all more obvious to the users, so that they are less likely to go a report a bug before they actually encounter one.
To make this issue as constructive as possible, here's a suggestion for how a clearer warning message could look like:
The text was updated successfully, but these errors were encountered: