-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] URL to faulty module's page is run-in with following sentence, merging the two #73
Comments
Thank you so much for this detailed bug report! I don't have time right now to look into it, but I'll try to find some time this week. |
What browser are you using? Also what version of the pf1 sheet module are you using? Any other requirements to see this exact message? I am unable to reproduce, unfortunately. All such errors I can generate myself have the proper line-break at that position. |
It appeared while I was developing the module more and I caused bugs. PF1 0.82.2, Foundry 10.290 with Electron client, Win10,... I don't think there's anything unusual about the URL field either to cause it: https://gitlab.com/koboldworks/pf1/sheet/-/blob/master/release/module.json#L37 |
What was the exact exception type? For instance, They have different code paths for the message, so it would help narrow it down. |
That I do not remember. And I don't remember what the error itself was. I can try making something break, I guess. |
Nevermind, I think I found the problem. Thanks for the help! |
Well, for post-humous reasons... const registerSheetOverride = () => {
if (!game.settings.get(CFG.id, CFG.SETTINGS.defaultInfoSheet)) return;
/* global libWrapper */
libWrapper.register(CFG.id, Item.prototype._getSheetClass, softOverrideDefaultSheet, libWrapper.MIXED);
}
Hooks.once('init', registerSheetOverride); Missing quotes on the override target. |
Fixed in v1.12.11.0. Thanks for your help! Turns out I had broken this in v1.12.9.0. Closing this, let me know if you encounter this again. |
Confirm you have read the above
The bug is in libWrapper's own error about it not being libWrapper error.
Describe the bug
"Report this issue here:" text is run in with previous URL, causing the "Report" part to be part of the URL.
Example of the bit in question:
Notice how
Report
is run-in with the URL?To Reproduce
Steps to reproduce the behavior:
Expected behavior
The link to not include "Report" from the following sentence.
Screenshots

Technical Details (please complete the following information):
The text was updated successfully, but these errors were encountered: