Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger hooks when OVERRIDE wrappers get overridden. #23

Closed
ruipin opened this issue Feb 10, 2021 · 1 comment
Closed

Trigger hooks when OVERRIDE wrappers get overridden. #23

ruipin opened this issue Feb 10, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@ruipin
Copy link
Owner

ruipin commented Feb 10, 2021 •
edited
Loading

If an existing OVERRIDE wrapper gets taken over by a different module because they have priority, right now modules are not notified.

It might make sense to add an option API to allow modules to set a callback that should be fired when this event happens.

This could use the Hooks system, e.g. a hook libWrapper.OverrideLost

Might make sense to add this also for similar events, e.g. libWrapper.ConflictDetected.
@ruipin ruipin added the enhancement New feature or request label Feb 10, 2021
@ruipin ruipin changed the title Allow modules to set a callback for when OVERRIDE wrappers get overridden,. Allow hooks for when OVERRIDE wrappers get overridden,. Feb 10, 2021
@ruipin ruipin changed the title Allow hooks for when OVERRIDE wrappers get overridden,. Triggers hooks when OVERRIDE wrappers get overridden. Feb 12, 2021
@ruipin ruipin changed the title Triggers hooks when OVERRIDE wrappers get overridden. Trigger hooks when OVERRIDE wrappers get overridden. Apr 10, 2021
@ruipin ruipin closed this as completed in 08bfb67 Apr 11, 2021
@ruipin
Copy link
Owner Author

ruipin commented Apr 11, 2021

This is now done in v1.4.0.0, closing.

All newly added hooks are now documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ruipin