Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for systems, world scripts and macros #19

Closed
ruipin opened this issue Feb 9, 2021 · 2 comments
Closed

Add support for systems, world scripts and macros #19

ruipin opened this issue Feb 9, 2021 · 2 comments
Assignees
@ruipin
Labels
enhancement New feature or request

Comments

@ruipin
Copy link
Owner

ruipin commented Feb 9, 2021 •
edited
Loading

Currently, world scripts and macros are unable to use libWrapper as they do not have a module ID.

It might be a good idea to come up with a special ID that can be used for those cases. For example, "SCRIPTS" or 0.

In addition, systems can't use libWrapper either. While they usually won't need it, since they run first, might make sense to add support in case someone wants to patch things after init.
@ruipin ruipin added the enhancement New feature or request label Feb 9, 2021
@ruipin ruipin changed the title Add support for world scripts and macros Add support for systems, world scripts and macros Feb 10, 2021
@ruipin
Copy link
Owner Author

ruipin commented Apr 11, 2021

v1.4.2.0 adds support for systems.

In addition to systems now being correctly detected when conflicts occur (instead of showing up as unknown), they may now also register wrappers using the system ID.

@ruipin ruipin mentioned this issue May 5, 2021
Closed
@ruipin
Copy link
Owner Author

ruipin commented May 5, 2021 •
edited
Loading

v1.5.4.0 adds support for world scripts, and updates the shim with auto-detection capability of world and/or system IDs.

Closing.

@ruipin ruipin closed this as completed May 5, 2021
@ruipin ruipin self-assigned this May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruipin ruipin

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ruipin