Fix Amazon search with spaces (#192)

* Add Spec to search items with spaces

* Add search with spaces xml response

* Add webmock config for search with spaces

* Update amazon_item_search_endpoint to convert spaces to underscore in request

* Update webmock return an error query request to use underscores

* Update xml response

* Fix robocop comments

Author: Maxscores

.ruby-version

@@ -0,0 +1 @@
+2.4.1

lib/amazon_product_api/item_search_endpoint.rb

@@ -84,7 +84,7 @@ def params
         'Operation'       => 'ItemSearch',
         'ResponseGroup'   => 'ItemAttributes,Offers,Images',
         'SearchIndex'     => 'All',
-        'Keywords'        => query.to_s,
+        'Keywords'        => query.to_s.tr(' ', '_'),
         'ItemPage'        => page.to_s
       }
 

spec/features/managing_items_and_wishlists_spec.rb

@@ -35,6 +35,15 @@
       expect(page).to have_text 'Needed: 18'
     end
 
+    scenario 'I can search for items with spaces', :external do
+      visit wishlist_path(wishlist)
+      click_link 'Add to Wishlist'
+      fill_in 'search_field', with: 'corgi pillow'
+      click_button 'Search Amazon'
+
+      expect(page).to_not have_text 'Could not connect to Amazon.'
+    end
+
     scenario 'I get redirected to the search page when Amazon returns an error code.', :external do
       visit wishlist_path(wishlist)
       click_link 'Add to Wishlist'

spec/fixtures/files/amazon_corgi_pillow_search_response.xml

@@ -13,6 +13,13 @@
                                   'Keywords'  => 'corgi'))
       .to_return(body: search_response)
 
+    # Item Search with Spaces
+    search_response = file_fixture('amazon_corgi_pillow_search_response.xml').read
+    stub_request(:get, 'webservices.amazon.com/onca/xml')
+      .with(query: hash_including('Operation' => 'ItemSearch',
+                                  'Keywords'  => 'corgi_pillow'))
+      .to_return(body: search_response)
+
     # Item Lookup
     lookup_response = file_fixture('amazon_corgi_lookup_response.xml').read
     stub_request(:get, 'webservices.amazon.com/onca/xml')
@@ -21,7 +28,7 @@
       .to_return(body: lookup_response)
 
     stub_request(:get, 'webservices.amazon.com/onca/xml')
-      .with(query: hash_including('Keywords' => 'return an error'))
+      .with(query: hash_including('Keywords' => 'return_an_error'))
       .to_return(status: 500)
   end
 end