rubyforgood
diff --git a/‎.pryrc
+3-3 b/‎.pryrc
+3-3
diff --git a/‎.rubocop.yml
+19 b/‎.rubocop.yml
+19
diff --git a/‎.rubocop_todo.yml
+41 b/‎.rubocop_todo.yml
+41
diff --git a/‎Gemfile
+30-14 b/‎Gemfile
+30-14
diff --git a/‎Gemfile.lock
+17 b/‎Gemfile.lock
+17
diff --git a/‎Rakefile
+5-2 b/‎Rakefile
+5-2
diff --git a/‎app/channels/application_cable/channel.rb
+2 b/‎app/channels/application_cable/channel.rb
+2
diff --git a/‎app/channels/application_cable/connection.rb
+2 b/‎app/channels/application_cable/connection.rb
+2
diff --git a/‎app/controllers/amazon_search_controller.rb
+22-20 b/‎app/controllers/amazon_search_controller.rb
+22-20
diff --git a/‎app/controllers/application_controller.rb
+13-10 b/‎app/controllers/application_controller.rb
+13-10
@@ -1,3 +1,3 @@
-if defined?(PryRails::RAILS_PROMPT)
-  Pry.config.prompt = PryRails::RAILS_PROMPT
-end
+# frozen_string_literal: true
+
+Pry.config.prompt = PryRails::RAILS_PROMPT if defined?(PryRails::RAILS_PROMPT)
@@ -0,0 +1,19 @@
+inherit_from: .rubocop_todo.yml
+
+AllCops:
+  # Use the following Exclude to prevent Rubocop from linting specific
+  # directories or files.
+  Exclude:
+    - db/**/*
+  TargetRubyVersion: 2.4.1
+  # Cop names are not displayed in offense messages by default. Change behavior
+  # by overriding DisplayCopNames, or by giving the `-D/--display-cop-names`
+  # option.
+  DisplayCopNames: true
+  # Style guide URLs are not displayed in offense messages by default. Change
+  # behavior by overriding `DisplayStyleGuide`, or by giving the
+  # `-S/--display-style-guide` option.
+  DisplayStyleGuide: true
+
+Style/NumericLiterals:
+  Enabled: false
@@ -0,0 +1,41 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2017-10-19 07:48:24 -0700 using RuboCop version 0.50.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+Metrics/AbcSize:
+  Max: 19
+
+# Offense count: 51
+# Configuration parameters: CountComments, ExcludedMethods.
+Metrics/BlockLength:
+  Max: 305
+
+# Offense count: 33
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Metrics/LineLength:
+  Max: 117
+
+# Offense count: 1
+# Configuration parameters: CountComments.
+Metrics/MethodLength:
+  Max: 12
+
+# Offense count: 1
+# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
+# NamePrefix: is_, has_, have_
+# NamePrefixBlacklist: is_, has_, have_
+# NameWhitelist: is_a?
+Naming/PredicateName:
+  Exclude:
+    - 'spec/**/*'
+    - 'lib/amazon_product_api/search_item.rb'
+
+# Offense count: 49
+Style/Documentation:
+  Enabled: false
@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 ruby '2.4.1'
 
 git_source(:github) do |repo_name|
-  repo_name = "#{repo_name}/#{repo_name}" unless repo_name.include?("/")
+  repo_name = "#{repo_name}/#{repo_name}" unless repo_name.include?('/')
   "https://github.com/#{repo_name}.git"
 end
 
@@ -24,7 +26,8 @@ gem 'newrelic_rpm'
 gem 'dotenv-rails'
 # Logs production errors to an external service
 gem 'rollbar'
-# Turbolinks makes navigating your web application faster. Read more: https://github.com/turbolinks/turbolinks
+# Turbolinks makes navigating your web application faster.
+# Read more: https://github.com/turbolinks/turbolinks
 gem 'turbolinks', '~> 5'
 # Build JSON APIs with ease. Read more: https://github.com/rails/jbuilder
 gem 'jbuilder', '~> 2.5'
@@ -35,13 +38,15 @@ gem 'jquery-rails', '~> 4.3.1'
 source 'https://rails-assets.org' do
   gem 'rails-assets-tether', '>= 1.3.3'
 end
-# The most popular HTML, CSS, and JavaScript framework for developing responsive, mobile first projects on the web.
+# The most popular HTML, CSS, and JavaScript framework for developing
+# responsive, mobile first projects on the web.
 gem 'bootstrap', '~> 4.0.0.alpha6'
 # Login with Amazon OAuth2 strategy for OmniAuth 1.0
 gem 'omniauth-amazon'
 # Makes http fun again! http://jnunemaker.github.com/httparty
 gem 'httparty'
-# Helper for add social share feature in your Rails app. Twitter, Facebook, Weibo, Douban
+# Helper for add social share feature in your Rails app. Twitter, Facebook,
+# Weibo, Douban
 gem 'social-share-button', '~> 1.0.0'
 # most important gem for awesome debugging and awesome consoles
 gem 'pry-rails'
@@ -50,11 +55,14 @@ gem 'pundit'
 
 gem 'font-awesome-sass'
 group :development, :test do
-  # Call 'byebug' anywhere in the code to stop execution and get a debugger console
-  gem 'byebug', platforms: [:mri, :mingw, :x64_mingw]
+  # Call 'byebug' anywhere in the code to stop execution and get a debugger
+  # console
+  gem 'byebug', platforms: %i[mri mingw x64_mingw]
   # Adds support for Capybara system testing and selenium driver
   gem 'capybara', '~> 2.13'
-  # WebDriver is a tool for writing automated tests of websites. It aims to mimic the behaviour of a real user, and as such interacts with the HTML of the application.
+  # WebDriver is a tool for writing automated tests of websites. It aims to
+  # mimic the behaviour of a real user, and as such interacts with the HTML of
+  # the application.
   gem 'selenium-webdriver'
   # rspec-rails is a testing framework for Rails 3+.
   gem 'rspec-rails', '~> 3.5'
@@ -63,20 +71,26 @@ group :development, :test do
 end
 
 group :development do
-  # Access an IRB console on exception pages or by using <%= console %> anywhere in the code.
+  # Access an IRB console on exception pages or by using <%= console %> anywhere
+  # in the code.
   gem 'web-console', '>= 3.3.0'
   # Annotate model/model spec/factory files with the database schema
   gem 'annotate', '~> 2.7'
-  # The Listen gem listens to file modifications and notifies you about the changes. https://rubygems.org/gems/listen
+  # The Listen gem listens to file modifications and notifies you about the
+  # changes. https://rubygems.org/gems/listen
   gem 'listen', '>= 3.0.5', '< 3.2'
-  # Spring speeds up development by keeping your application running in the background. Read more: https://github.com/rails/spring
+  # Spring speeds up development by keeping your application running in the
+  # background. Read more: https://github.com/rails/spring
   gem 'spring'
-  # This gem makes Spring watch the filesystem for changes using Listen rather than by polling the filesystem.
+  # This gem makes Spring watch the filesystem for changes using Listen rather
+  # than by polling the filesystem.
   gem 'spring-watcher-listen', '~> 2.0.0'
   # Implements the `rspec` command for Spring, allowing for faster test loading
   gem 'spring-commands-rspec', '~> 1.0'
   # Helps detect N+1 queries and unused eager loading
   gem 'bullet'
+  # Ruby's style guide enforcer
+  gem 'rubocop'
   gem 'binding_of_caller', '~> 0.7'
   gem 'better_errors', '~> 2.1'
   gem 'capistrano-rails', '~> 1.2'
@@ -87,13 +101,15 @@ group :development do
 end
 
 group :test do
-  # Allows you to launch a debugging snapshot in your browser during Capybara tests
+  # Allows you to launch a debugging snapshot in your browser during Capybara
+  # tests
   gem 'launchy', '~> 2.4.3'
-  # A set of strategies for cleaning your database (ensuring a clean slate during tests)
+  # A set of strategies for cleaning your database (ensuring a clean slate
+  # during tests)
   gem 'database_cleaner', '~> 1.6.1'
   # Library for stubbing and setting expectations on HTTP requests in Ruby.
   gem 'webmock', '~> 3.0'
 end
 
 # Windows does not include zoneinfo files, so bundle the tzinfo-data gem
-gem 'tzinfo-data', platforms: [:mingw, :mswin, :x64_mingw, :jruby]
+gem 'tzinfo-data', platforms: %i[mingw mswin x64_mingw jruby]
@@ -47,6 +47,7 @@ GEM
       activerecord (>= 3.2, < 6.0)
       rake (>= 10.4, < 13.0)
     arel (8.0.0)
+    ast (2.3.0)
     autoprefixer-rails (7.1.1)
       execjs
     better_errors (2.3.0)
@@ -180,7 +181,11 @@ GEM
     omniauth-oauth2 (1.4.0)
       oauth2 (~> 1.0)
       omniauth (~> 1.2)
+    parallel (1.12.0)
+    parser (2.4.0.0)
+      ast (~> 2.2)
     pg (0.20.0)
+    powerpack (0.1.1)
     pry (0.10.4)
       coderay (~> 1.1.0)
       method_source (~> 0.8.1)
@@ -218,6 +223,8 @@ GEM
       method_source
       rake (>= 0.8.7)
       thor (>= 0.18.1, < 2.0)
+    rainbow (2.2.2)
+      rake
     rake (12.0.0)
     rb-fsevent (0.9.8)
     rb-inotify (0.9.8)
@@ -241,6 +248,14 @@ GEM
       rspec-mocks (~> 3.6.0)
       rspec-support (~> 3.6.0)
     rspec-support (3.6.0)
+    rubocop (0.50.0)
+      parallel (~> 1.10)
+      parser (>= 2.3.3.1, < 3.0)
+      powerpack (~> 0.1)
+      rainbow (>= 2.2.2, < 3.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (~> 1.0, >= 1.0.1)
+    ruby-progressbar (1.9.0)
     ruby_dep (1.5.0)
     rubyzip (1.2.1)
     safe_yaml (1.0.4)
@@ -287,6 +302,7 @@ GEM
       thread_safe (~> 0.1)
     uglifier (3.2.0)
       execjs (>= 0.3.0, < 3)
+    unicode-display_width (1.3.0)
     uniform_notifier (1.10.0)
     web-console (3.5.1)
       actionview (>= 5.0)
@@ -339,6 +355,7 @@ DEPENDENCIES
   rails-assets-tether (>= 1.3.3)!
   rollbar
   rspec-rails (~> 3.5)
+  rubocop
   sass-rails (~> 5.0)
   selenium-webdriver
   social-share-button (~> 1.0.0)
 
@@ -1,8 +1,11 @@
+# frozen_string_literal: true
+
 # Add your own tasks in files placed in lib/tasks ending in .rake,
-# for example lib/tasks/capistrano.rake, and they will automatically be available to Rake.
+# for example lib/tasks/capistrano.rake, and they will automatically be
+# available to Rake.
 
 require_relative 'config/application'
 
 Rails.application.load_tasks
 
-task default: [:"factory_bot:lint", :spec]
+task default: %i[factory_bot:lint spec]
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ApplicationCable
   class Channel < ActionCable::Channel::Base
   end
 
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ApplicationCable
   class Connection < ActionCable::Connection::Base
   end
 
@@ -1,5 +1,7 @@
-require "amazon_product_api"
-require "nested_wishlist_context"
+# frozen_string_literal: true
+
+require 'amazon_product_api'
+require 'nested_wishlist_context'
 
 class AmazonSearchController < ApplicationController
   before_action :set_wishlist
@@ -15,22 +17,22 @@ def new
   end
 
   private
-    def amazon_client
-      AmazonProductAPI::HTTPClient.new(query: params[:query],
-                                       page_num: params[:page_num] || 1)
-    end
-
-    def set_wishlist
-      @wishlist = Wishlist.find(params[:wishlist_id])
-    end
-
-    def pundit_user
-      NestedWishlistContext.new(current_user, @wishlist)
-    end
-
-    def filter_search
-      if params[:query].blank?
-        redirect_to new_wishlist_amazon_search_path, notice: "query can't be blank"
-      end
-    end
+
+  def amazon_client
+    AmazonProductAPI::HTTPClient.new(query: params[:query],
+                                     page_num: params[:page_num] || 1)
+  end
+
+  def set_wishlist
+    @wishlist = Wishlist.find(params[:wishlist_id])
+  end
+
+  def pundit_user
+    NestedWishlistContext.new(current_user, @wishlist)
+  end
+
+  def filter_search
+    params[:query].blank? && redirect_to(new_wishlist_amazon_search_path,
+                                         notice: "query can't be blank")
+  end
 end
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ApplicationController < ActionController::Base
   include Pundit
   protect_from_forgery with: :exception
@@ -9,16 +11,17 @@ class ApplicationController < ActionController::Base
   rescue_from Pundit::NotAuthorizedError, with: :user_not_authorized
 
   private
-    def current_user
-      return @current_user if @current_user
-      @current_user = User.find_by(id: session[:user_id]) || GuestUser.new
-    end
 
-    def set_wishlists
-      @wishlists = Wishlist.all
-    end
+  def current_user
+    return @current_user if @current_user
+    @current_user = User.find_by(id: session[:user_id]) || GuestUser.new
+  end
+
+  def set_wishlists
+    @wishlists = Wishlist.all
+  end
 
-    def user_not_authorized
-      redirect_to root_url, alert: "You are not authorized to view that page."
-    end
+  def user_not_authorized
+    redirect_to root_url, alert: 'You are not authorized to view that page.'
+  end
 end
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`module ApplicationCable`
`2`	`4`	`class Channel < ActionCable::Channel::Base`
`3`	`5`	`end`