Fix current violations and remove todo. (#188)

- Huzzah!!!

Author: mxygem

.rubocop.yml

@@ -1,5 +1,3 @@
-inherit_from: .rubocop_todo.yml
-
 AllCops:
   # Use the following Exclude to prevent Rubocop from linting specific
   # directories or files.
@@ -27,6 +25,9 @@ Metrics/BlockLength:
     - spec/**/*
     - config/**/*
 
+Metrics/LineLength:
+  Enabled: False
+
 Metrics/MethodLength:
   Max: 12
 

.rubocop_todo.yml

@@ -10,9 +10,7 @@ class AmazonSearchController < ApplicationController
   def show
     authorize :amazon_search, :show?
     @response = amazon_search_response
-    if @response.error?
-      redirect_to new_wishlist_amazon_search_path(params[:wishlist_id]), notice: 'Could not connect to Amazon. Please try again later or contact the website adminitrator.'
-    end
+    redirect_to new_wishlist_amazon_search_path(params[:wishlist_id]), notice: 'Could not connect to Amazon. Please try again later or contact the website adminitrator.' if @response.error?
   end
 
   def new

app/controllers/amazon_search_controller.rb

@@ -44,14 +44,12 @@ def get(http: HTTParty)
 
     # Performs the search query and returns the resulting SearchResponse
     def response(http: HTTParty, logger: Rails.logger)
-      begin
-        response = get(http: http)
-        logger.debug response
-        SearchResponse.new(parse_response(response), response.code)
-      rescue StandardError => e
-        Rollbar.error(e, "Failed to connect to Amazon. Reqeust: #{http}")
-        SearchResponse.new({}, 500)
-      end
+      response = get(http: http)
+      logger.debug response
+      SearchResponse.new(parse_response(response), response.code)
+    rescue StandardError => e
+      Rollbar.error(e, "Failed to connect to Amazon. Reqeust: #{http}")
+      SearchResponse.new({}, 500)
     end
 
     private

lib/amazon_product_api/item_search_endpoint.rb

@@ -9,7 +9,6 @@ module AmazonProductAPI
   # this class. By isolating it from the rest of the codebase, we only have one
   # file to touch if the API response changes.
   class SearchResponse
-
     SUCCESS_CODE_RANGE = (200..299)
     FOUND_CODE = 302
     NOT_MODIFIED = 304

lib/amazon_product_api/search_response.rb

@@ -35,21 +35,21 @@
       expect(page).to have_text 'Needed: 18'
     end
 
-    scenario "I get redirected to the search page when Amazon returns an error code.", :external do
+    scenario 'I get redirected to the search page when Amazon returns an error code.', :external do
       visit wishlist_path(wishlist)
-      click_link "Add to Wishlist"
-      fill_in "search_field", with: "return an error" # Triggers webmock to return 500
-      click_button "Search Amazon"
+      click_link 'Add to Wishlist'
+      fill_in 'search_field', with: 'return an error' # Triggers webmock to return 500
+      click_button 'Search Amazon'
 
       expect(page).to have_text 'Could not connect to Amazon'
     end
 
-    scenario "I get redirected to the search page when the call to Amazon to connect.", :external do
+    scenario 'I get redirected to the search page when the call to Amazon to connect.', :external do
       allow(HTTParty).to receive(:get).and_raise(HTTParty::Error)
       visit wishlist_path(wishlist)
-      click_link "Add to Wishlist"
-      fill_in "search_field", with: "corgi"
-      click_button "Search Amazon"
+      click_link 'Add to Wishlist'
+      fill_in 'search_field', with: 'corgi'
+      click_button 'Search Amazon'
 
       expect(page).to have_text 'Could not connect to Amazon'
     end

spec/features/managing_items_and_wishlists_spec.rb

@@ -15,8 +15,8 @@
   end
   let(:blank_response) { AmazonProductAPI::SearchResponse.new({}, 200) }
   let(:full_response)  { AmazonProductAPI::SearchResponse.new(response_hash, 200) }
-  let(:success_codes) { [ 200, 204, 302, 304 ] }
-  let(:failure_codes) { [ 400, 500 ] }
+  let(:success_codes) { [200, 204, 302, 304] }
+  let(:failure_codes) { [400, 500] }
 
   describe '#num_pages' do
     context 'no page number is present' do