-
-
Notifications
You must be signed in to change notification settings - Fork 540
5118 down arrow to select elements #5126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5118 down arrow to select elements #5126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @panacotar -- thanks for taking this on.
Alas, your solution has side effects -- we end up with doubled arrows. See below (this is on the distributions, but the same would occur anywhere we have items, at least, which is most of the forms in the system)
@dorner -- do you have insight on our best approach here? -- I like the idea of having all the drop-downs have the same mechanism, but I don't know if there are other considerations.
You are right, I missed that. On the issue, the Partner Profile Sections input is a select2 multi-box. I noticed that it is meant for multi-box selects to be without the arrow, you can see in the official documentation: We can still add an arrow to it using CSS. Here is an example how: |
CL has confirmed that this is ok, functionally, but we potentially have more to do.
Hey @pancotar -- I did a pass through the app to check everything, and I noticed a couple of other instances. -- specifically that when you do a new 'quantity' request on behalf of a partner, neither the drop-down for selecting the partner nor the drop-down for selecting the item have down arrows. I think this is pre-existing, and it's technically out of scope of what was asked for --- would you like to add it in, or should we make up a new issue for it (to see what I mean: sign in as org_Admin1@example.com, select "requests" then "New Quantity Request". |
I will add these fixes as well. The original 5118 issue asked for all dropdowns to be fixed, so it falls under this. |
I added the missing arrow to 3 more selects:
|
LGTM -- over to @dorner for any technical concerns. |
@panacotar: Your PR |
Resolves #5118
Description
There are two types of select elements here:
For the first one, the majority of the inputs are wrapped in
input-group
. So I decided to extend theform-select
class for those. This applies to allselect
elements wrapped ininput-group
.I tried to handle it in the config file > input_group. But without success, adding
form-select
class here will add it to all inputs, I couldn't find a way to add it only to theselect
tags.For select2 JS, I appended the
form-select
class in the select2 controller during the component initialization.Type of change
How Has This Been Tested?
Screenshots