-
-
Notifications
You must be signed in to change notification settings - Fork 540
5084 Display Drive Count on Summary page for Selected Dates #5114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5084 Display Drive Count on Summary page for Selected Dates #5114
Conversation
a2bda34
to
66ffd26
Compare
Hey @christianloring -- this looks good to me functionally . I've noticed some other things that are amiss with this report when I was testing (notably that it would be nice to have the year in the period) , but I'll write them up as separate issues. I'm passing this over to our technical reviewers to see if they have any input. |
I also note that the lint is failing -- just looks like a whitespace issue. |
535c218
to
57acbf4
Compare
57acbf4
to
0bc6f44
Compare
Note for future -- we prefer that you don't do force-pushes once we start the review process -- it's easier on the review team if they can see the differences between what was previously reviewed and your new offering. |
Sorry about that and thanks for the heads up, I'll make sure to avoid force pushing in the future once PRs are under review. |
@dorner -- I think this one is waiting for your review. |
@christianloring: Your PR |
Resolves #5084
Description
This adds a new line at the top of the summary information about the number of drives following the following format:
[number of drives] drives active during the period [start date] to [end date]
Type of change
How Has This Been Tested?
Tested via RSpec and checking the page in the local browser.
Screenshots