Skip to content

5084 Display Drive Count on Summary page for Selected Dates #5114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

christianloring
Copy link
Contributor

@christianloring christianloring commented Mar 23, 2025

Resolves #5084

Description

This adds a new line at the top of the summary information about the number of drives following the following format:
[number of drives] drives active during the period [start date] to [end date]

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested via RSpec and checking the page in the local browser.

Screenshots

Screenshot 2025-03-22 at 11 09 54 PM

@christianloring christianloring force-pushed the 5084-product-drives-summary-count branch 4 times, most recently from a2bda34 to 66ffd26 Compare March 23, 2025 19:33
@christianloring christianloring marked this pull request as ready for review March 25, 2025 02:25
@christianloring
Copy link
Contributor Author

christianloring commented Mar 25, 2025

In the screenshot, there are 3 drives listed at the bottom, while the first line's text says 2 drives active during.... The discrepancy is because my local database was set up when I cloned the app, so it doesn’t fully represent real data. Additionally, Drive ID 1 (shown below) shows a created_at date of March 22nd, 2025, the day I cloned the app, even though the drive itself started and ended in 2022.

Screenshot 2025-03-24 at 10 42 07 PM

Since this is my first ticket, please let me know if there’s anything I should improve or clarify. I'm happy to make adjustments.

@christianloring christianloring changed the title WIP - 5084 Display Drive Count on Summary page for Selected Dates 5084 Display Drive Count on Summary page for Selected Dates Mar 25, 2025
@cielf
Copy link
Collaborator

cielf commented Mar 25, 2025

Hey @christianloring -- this looks good to me functionally . I've noticed some other things that are amiss with this report when I was testing (notably that it would be nice to have the year in the period) , but I'll write them up as separate issues.

I'm passing this over to our technical reviewers to see if they have any input.

@cielf cielf requested review from awwaiid and dorner March 25, 2025 18:05
@cielf
Copy link
Collaborator

cielf commented Mar 25, 2025

I also note that the lint is failing -- just looks like a whitespace issue.

@christianloring christianloring force-pushed the 5084-product-drives-summary-count branch from 535c218 to 57acbf4 Compare March 25, 2025 19:40
@christianloring christianloring force-pushed the 5084-product-drives-summary-count branch from 57acbf4 to 0bc6f44 Compare March 25, 2025 19:43
@cielf
Copy link
Collaborator

cielf commented Mar 25, 2025

Note for future -- we prefer that you don't do force-pushes once we start the review process -- it's easier on the review team if they can see the differences between what was previously reviewed and your new offering.

@christianloring
Copy link
Contributor Author

Sorry about that and thanks for the heads up, I'll make sure to avoid force pushing in the future once PRs are under review.

@cielf
Copy link
Collaborator

cielf commented Apr 19, 2025

@dorner -- I think this one is waiting for your review.

@dorner dorner merged commit 2abc01c into rubyforgood:main Apr 22, 2025
11 checks passed
Copy link
Contributor

@christianloring: Your PR 5084 Display Drive Count on Summary page for Selected Dates is part of today's Human Essentials production release: 2025.04.27.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Product Drives Summary - please show the number of drives held in the date range selected.
3 participants