validates the item purchase fields for diapers, #5076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adult incontinence, period, other as >= 0, added tests
cielf
requested changes
Mar 7, 2025
| expect(d).not_to be_valid | ||
| end | ||
|
|
||
| it "is valid if all categories are positive" do |
There was a problem hiding this comment.
I would say "is valid if all categories are positive and add up to the total"
|
@dorner -- do you want to take a technical pass on this? My nitpick is small enough that we could just edit the file on behalf of @jahuang415 , methinks. |
dorner
requested changes
Apr 8, 2025
| @@ -54,6 +54,29 @@ | |||
| expect(d).to be_valid | |||
| end | |||
|
|
|||
| # re 5059-non-negative-purchase_value, adding in amount_spent_on_period_supplies_cents to test. | |||
| # also adding in amount_spend_on_incontinence_cents because it was missing. | |||
There was a problem hiding this comment.
This comment isn't necessary - this belongs in the PR, not in the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5059
Description
Before the change, a user could a new purchase with negative dollar values for the respective items (other, incontinence, etc.) and it would be valid so long as the total sum was correct and greater than zero.
A validation was added such that each purchase item must be greater than or equal to zero, and a respective rspec test was added to check.
Type of change
How Has This Been Tested?
Create a new purchase, and set the following values respectively: 1, -1, 2, 0, 0. This will submit successfully, which is incorrect.
Following the change, this will produce an error and not submit.