Skip to content

Reorganization of organization edit and view pages #5116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 4, 2025
Merged

Reorganization of organization edit and view pages #5116

merged 12 commits into from
Apr 4, 2025

Conversation

jp524
Copy link
Contributor

@jp524 jp524 commented Mar 23, 2025

Resolves #5055

Description

Reorganizes the organization edit and view pages per the issue description. I've also made some other tweaks:

  • Fixed the UI in a couple of spots where it looked odd
  • Updated the heading names slightly to ensure consistent capitalization, per the document style guide

I did notice that the select dropdowns didn't have a down arrow. This affects the following selects:

  • NDBN membership ID
  • Default Intake Location
  • Default Profile Sections
  • Default Storage Location

I briefly looked into it and it seems like there was a change in how Bootstrap handle select elements. I'll open a new issue to address this.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

How Has This Been Tested?

Updated existing specs to match the new text on the views.

Screenshots

View page

Before After
show 1 show 1
show 2 show 2
show 3

Edit page

Before After
edit 1 edit 1
edit 2 edit 2
edit 3 edit 3

@cielf cielf self-requested a review March 24, 2025 14:38
cielf
cielf previously requested changes Mar 24, 2025
View reviewed changes
Copy link
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jp524

A couple of adjustments, please:

1/ Please move "Receive email when Partner makes a Request?" to "Other emails". (this was added after the initial writeup, I think).

2/ Since you're changing the headers, "Item" in "Enable Partners to make Requests by indicating number of individuals needing each item?" would be capitalized.

I'm holding off reviewing the user guide until those are in.

Thanks!

@jp524 jp524 requested a review from cielf March 24, 2025 23:11
cielf
cielf reviewed Mar 25, 2025
View reviewed changes
Copy link
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM passing it to @awwaiid for a quick once over, but I'm pretty sure everything here is just moving or changing capitalization.

@cielf cielf requested review from awwaiid and dorner March 25, 2025 16:59
@cielf cielf mentioned this pull request Mar 27, 2025
Open
@dorner
Copy link
Collaborator

dorner commented Mar 28, 2025

@jp524 there are a bunch of conflicts - can you please resolve them first?

@jp524
Copy link
Contributor Author

jp524 commented Mar 29, 2025

@dorner Merge conflicts have been resolved; it's ready for your review.

@dorner dorner merged commit 4b1cb83 into rubyforgood:main Apr 4, 2025
12 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 6, 2025

@jp524: Your PR Reorganization of organization edit and view pages is part of today's Human Essentials production release: 2025.04.06.
Thank you very much for your contribution!

@jp524 jp524 deleted the 5505-reorganize-organization-pages branch April 19, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cielf cielf cielf left review comments

@dorner dorner dorner approved these changes

@awwaiid awwaiid Awaiting requested review from awwaiid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reorganization of organization edits and view
3 participants
@jp524 @dorner @cielf