Add stub signatures for Rack gem #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I created the prototype of signatures by applying TypeProf to Rack and editting the result manually. ``` bundle exec typeprof -Ilib example/lobster.ru -o sig/rack.rbs ``` I've checked that `rbs validate` passed. There are still many glitches, but I believe that this is a good start to create the RBS of Rack.
pocke
reviewed
Jul 14, 2021
gems/rack/2.2.2/_test/Steepfile
Outdated
| check "." | ||
|
|
||
| repo_path "../../../" | ||
| library "rainbow" |
pocke
added a commit
to pocke/rbs_rails
that referenced
this pull request
Jul 25, 2021
Because rack RBS has been added since ruby/gem_rbs_collection#36
This was referenced Jul 25, 2021
elishadiah
pushed a commit
to elishadiah/ROR-mine
that referenced
this pull request
Sep 20, 2022
Because rack RBS has been added since ruby/gem_rbs_collection#36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created the prototype of signatures by applying TypeProf to Rack and
editting the result manually.
I've checked that
rbs validatepassed.There are still many glitches, but I believe that this is a good start
to create the RBS of Rack.