Skip to content

Commit cc09e7d

Browse files
authored
Merge pull request #1075 from rubocop-hq/refactor-top-level-group
Use `case` instead of `if`
2 parents 38be753 + c61929a commit cc09e7d

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

lib/rubocop/cop/rspec/mixin/top_level_group.rb

+5-5
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ module TopLevelGroup
99

1010
def on_new_investigation
1111
super
12-
return unless root_node
1312

1413
top_level_groups.each do |node|
1514
on_top_level_example_group(node) if example_group?(node)
@@ -34,11 +33,12 @@ def top_level_group?(node)
3433
end
3534

3635
def top_level_nodes(node)
37-
if node.nil?
38-
[]
39-
elsif node.begin_type?
36+
return [] if node.nil?
37+
38+
case node.type
39+
when :begin
4040
node.children
41-
elsif node.module_type? || node.class_type?
41+
when :module, :class
4242
top_level_nodes(node.body)
4343
else
4444
[node]

0 commit comments

Comments
 (0)