Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct endpoint for RsConnect get_user with guid #292

Merged
merged 6 commits into from
Aug 27, 2024
Merged

Use correct endpoint for RsConnect get_user with guid #292

merged 6 commits into from
Aug 27, 2024

Conversation

nathanjmcdougall
Copy link
Contributor

@nathanjmcdougall nathanjmcdougall commented Jul 25, 2024 •
edited
Loading

To fix #236.

@nathanjmcdougall
Copy link
Contributor Author

nathanjmcdougall commented Aug 6, 2024 •
edited
Loading

Something strange is going on with the ruff pre-commit. It seems to be using the "UP" and "FA" rules even though those aren't selected in this branch (they are selected in #289).
I wonder whether there is some strange cache contamination going on? Might be a good opportunity to work on #255.

I just needed to merge from main, I misunderstood the way the CI works.

isabelizimm
isabelizimm approved these changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@isabelizimm isabelizimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@isabelizimm isabelizimm merged commit 8faca6c into rstudio:main Aug 27, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isabelizimm isabelizimm isabelizimm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

connect: get_user() calls non-API user/{guid}
2 participants
@nathanjmcdougall @isabelizimm