Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fsspec): pass detail=False to ls to continue returning a list of strings #229

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

cpcloud
Copy link
Contributor

@cpcloud cpcloud commented Mar 19, 2024

This PR passes detail=False to the ls method calls in pins to allow compatibility with later versions of fsspec which have detail=True set as the default.

Copy link
Collaborator

@isabelizimm isabelizimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this update 🙌 LGTM!

@isabelizimm isabelizimm merged commit be9968d into rstudio:main Mar 22, 2024
24 checks passed
@cpcloud cpcloud deleted the fix-fsspec-compat branch March 23, 2024 09:59
@cpcloud
Copy link
Contributor Author

cpcloud commented Apr 11, 2024

@isabelizimm Any idea when this change might get released?

@isabelizimm
Copy link
Collaborator

Hey there! I'm shooting for early next week 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants