feat: preview r code in connect to read pin #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View it on Connect: https://colorado.posit.co/rsc/content/4a580f0f-91f2-40cc-a060-d2e2a5b090a4/ |
isabelizimm
commented
Nov 17, 2023
| @@ -1123,6 +1123,12 @@ def prepare_pin_version(self, pin_dir_path, x, name: "str | None", *args, **kwar | |||
| # TODO(compat): set display none in index.html | |||
| context["data_preview"] = json.dumps({}) | |||
|
|
|||
| # do not show r code if not round-trip friendly | |||
| if meta.type in ["joblib"]: | |||
There was a problem hiding this comment.
type options are "csv", "arrow", "parquet", "joblib", or "json". we will hide the R code if the pin is of joblib type
juliasilge
approved these changes
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parity to https://github.com/rstudio/pins-r/pull/806/files
closes #222
on preview in Posit Connect, users should be able to see how to load the data in R and Python if applicable.