Scale3d() flickers in Chrome 16 when the element is partially outside of the viewport #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've seen the 3D version of Scale() not work in Chrome when the element being scaled extends outside of the viewport. Thus, we're forcing Chrome to not use the 3d transforms as well. Not sure if translate is affected, but not risking it.
|
Nice catch! I can't reproduce this in Chrome15/Mac, though. ...But Chrome supports vanilla translate() and scale() anyway, so this can't be harmless, so I'll merge it to be sure. |
|
Btw, I'll optimize this a bit by putting the isChrome check further up in the file so that it'll only be done once. |
rstacruz
added a commit
that referenced
this pull request
Jan 24, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen the 3D version of Scale() not work in Chrome when the element being scaled extends outside of the viewport. I've posted a video showing the behavior using the http://ricostacruz.com/jquery.transit/ demo site.
http://www.youtube.com/watch?v=1I2xsVJQrIA&feature=youtu.be
This small change checks for Chrome and tells it to use non 3D transforms if it's found. I could see you wanting to refactor my tweak to something more elegant, but I mainly wanted to make you aware of this issue we discovered.