New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proc_int[sef] functions always access registers for core0 #904

Open

jannic opened this issue Feb 20, 2025 · 0 comments

Member

jannic commented Feb 20, 2025 •

edited

Loading

RP2040 has two sets of gpio interrupt registers, one for each core. The functions in

rp-hal/rp2040-hal/src/gpio/pin/pin_sealed.rs

Lines 30 to 32 in f98b41e

    
           fn proc_ints(&self, proc: CoreId) -> (&pac::io_bank0::PROC0_INTS, usize); 
        
           fn proc_inte(&self, proc: CoreId) -> (&pac::io_bank0::PROC0_INTE, usize); 
        
           fn proc_intf(&self, proc: CoreId) -> (&pac::io_bank0::PROC0_INTF, usize);

always access the registers for core0. Depending on the use case, this is wrong.

Possible solutions:

provide separate functions for each core
return correct register depending on proc: CoreId parameter
automatically select the register for the current core

Options 2 and 3 require more changes because the registers to be returned currently have different types. Maybe they could be unified in the PAC?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment