Clang Thread Safety Annotation Warning in rmw_get_topic_endpoint_info

[piraka9011]

Bug report

Required Info:

• Operating System:
  • Ubuntu 18.04
• Installation type:
  • Source
• Version or commit hash:
  • 465d15e
• DDS implementation:
  • FastRTPS
• Client library (if applicable):
  • N/A

Steps to reproduce issue

Building with --mixin clang-libcxx

Expected behavior

No warnings

Actual behavior

CI results in the following warnings

reading variable 'discovered_names' requires holding mutex 'slave_target->names_mutex_' [-Wthread-safety-analysis]

Additional information

It looks like there's already a guard here

guid_map_t discovered_names RCPPUTILS_TSA_GUARDED_BY(names_mutex_);

but it doesn't look like the macro is captured by TSAN.

[emersonknapp]

Just a nitpick - TSAN and Clang Thread Safety Annotations are different things, the title is incorrect