Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a memory check issue in split.c #104

Merged
merged 1 commit into from
Jun 4, 2018
Merged

Fix a memory check issue in split.c #104

merged 1 commit into from
Jun 4, 2018

Conversation

testkit
Copy link
Contributor

@testkit testkit commented Jun 4, 2018

string_array->data[0] should be checked after memory allocation.
Signed-off-by: testkit cathy.shen@intel.com

@testkit
Fix a memory check issue in split.c
3d05ad9 
Signed-off-by: testkit <cathy.shen@intel.com>
@tfoote tfoote added the in review Waiting for review (Kanban column) label Jun 4, 2018
Karsten1987
Karsten1987 approved these changes Jun 4, 2018
View reviewed changes
Copy link
Contributor

@Karsten1987 Karsten1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks for the patch!

@Karsten1987 Karsten1987 merged commit d4a86bd into ros2:master Jun 4, 2018
@Karsten1987 Karsten1987 removed the in review Waiting for review (Kanban column) label Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karsten1987 Karsten1987 Karsten1987 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@testkit @Karsten1987 @tfoote