[Windows] Check PYTHON_INSTALL_DIR before making directory. #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
reviewed
Aug 27, 2020
|
Thanks for the patch. |
dirk-thomas
pushed a commit
that referenced
this pull request
Aug 27, 2020
|
Cherry-picked to |
seanyen
added a commit
to ms-iot/catkin
that referenced
this pull request
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to reduce the
stderroutputs from a common code path. For building packages in a merged space, the code path to unconditionally createLib\site-packages(byPYTHON_INSTALL_DIR) will result in complaintsA subdirectory or file src already exists.tostderrfor the second and later packages exercising this flow.To reduce the noise to developers, this pull request is to only make directory when it doesn't exist.
Thanks for review and please consider to back-port to
kinetic-develif it makes sense.