Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catkin_prepare_release: adjust to svn 1.7+ when releasing subtrees of a repo #556

Closed
130s opened this issue Dec 3, 2013 · 5 comments
Closed

Comments

@130s
Copy link
Member

130s commented Dec 3, 2013

Starting from version 1.7, which comes with Ubuntu Raring, svn stopped generating .svn files in all folders.
http://subversion.apache.org/docs/release-notes/1.7.html#wc-ng

With projects downloaded by svn 1.7+ where ROS packages are placed in the subfolders (the case already handled in #513), catkin_prepare_release fails as follows:

$ cd %ROSPKG_SRCDIR_TOP%
$ catkin_prepare_release 
Prepare the source repository for a release.
Could not determine repository type of '.'
@dirk-thomas
Copy link
Member

If you are in the root of your working copy the command should work fine. None of the other VCS types allows you to invoke the command in a subfolder of the working copy.

This is only relevant if you are going to release a subtree of a SVN repository. Therefore I will mark this ticket with the milestone untargeted since it is not a feature the maintainers will work on. Please consider providing a patch if you want that use case to be supported.

@130s
Copy link
Member Author

130s commented Dec 5, 2013

I'm fine with setting this untargetted. Just as a record, there are ROS svn repositories that place packages in sub folders. A few of them are listed here.

@dirk-thomas
Copy link
Member

I just took a brief look to the referenced repos but none of them seems to contain catkin packages.

@130s
Copy link
Member Author

130s commented Dec 5, 2013

Ah, you're right! Those repos were the last stronghold for us to stick to place packages in subfolders. Now I'll suggest my team to change our long-lasting repository structure to more common way.

You can close this ticket if that's better.

@dirk-thomas
Copy link
Member

I will go ahead and close this ticket since there seems to be no interest in this feature.

@dirk-thomas dirk-thomas removed this from the untargeted milestone Jan 22, 2018
cwecht pushed a commit to cwecht/catkin that referenced this issue Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants