Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

catkin_prepare_release should assert buildtype catkin #478

Closed
tfoote opened this issue Jul 17, 2013 · 1 comment
Closed

catkin_prepare_release should assert buildtype catkin #478

tfoote opened this issue Jul 17, 2013 · 1 comment
Assignees
@dirk-thomas
Labels
enhancement

Comments

@tfoote
Copy link
Member

tfoote commented Jul 17, 2013

It's not guarenteed to work for non catkin packages. If it's a straight cmake or python package the version will be declared elsewhere and not be incremented correctly.
@ghost ghost assigned dirk-thomas Aug 5, 2013
@dirk-thomas
Copy link
Member

Rather than asserting the script should warn the user about it but allow him to override it and continue with the release.

cwecht pushed a commit to cwecht/catkin that referenced this issue Mar 20, 2018
@mikaelarguedas @wohe
Add Lunar to build matrix. (ros#478)
9867aeb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dirk-thomas dirk-thomas

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tfoote @dirk-thomas