rewrite catkin_prepare_release to execute the commands rather than printing them #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
| else: | ||
| assert False, 'Unknown vcs type: %s' % vcs_type | ||
| try: | ||
| output = subprocess.check_output(cmd, cwd=base_path, stderr=subprocess.STDOUT) |
There was a problem hiding this comment.
This is not python 2.6 compatible. but if we're only supporting groovy and higher that should be ok.
|
+1 |
dirk-thomas
added a commit
that referenced
this pull request
May 3, 2013
rewrite catkin_prepare_release to execute the commands rather than printing them
dirk-thomas
added a commit
that referenced
this pull request
Jun 6, 2013
cwecht
pushed a commit
to cwecht/catkin
that referenced
this pull request
Mar 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tfoote @wjwwood Please review and comment.
Also addresses #407.