-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
π₯β¨ boot kernel depending on context #169
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ben Word <ben@benword.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR changes how Acorn boots.
It more closely mirrors Laravel's boot process but applies a bit of logic to determine which Kernel to use.
π₯ BREAKING CHANGES
The following contain breaking changes:
All WordPress filters have been removed from the Bootloader.
This means that
acorn/bootstrap
,acorn/paths
,acorn/paths.{path}
, andacorn/ready
have been removed.This was done to limit unpredictable behavior. Since Acorn can boot much earlier, including instantly booting from a mu-plugin, then whether a filter is applied depends on the load order of plugins (or themes) that may try to use them.
A companion PR will be required in Sage's functions.php
closes #162