Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ’₯✨ boot kernel depending on context #169

Merged
merged 17 commits into from
Feb 6, 2022
Merged

Conversation

QWp6t
Copy link
Member

@QWp6t QWp6t commented Jan 31, 2022

Overview

This PR changes how Acorn boots.

It more closely mirrors Laravel's boot process but applies a bit of logic to determine which Kernel to use.

πŸ’₯ BREAKING CHANGES

The following contain breaking changes:

  • Bootloader class
  • bootloader function

All WordPress filters have been removed from the Bootloader.

This means that acorn/bootstrap, acorn/paths, acorn/paths.{path}, and acorn/ready have been removed.

This was done to limit unpredictable behavior. Since Acorn can boot much earlier, including instantly booting from a mu-plugin, then whether a filter is applied depends on the load order of plugins (or themes) that may try to use them.

A companion PR will be required in Sage's functions.php

-\Roots\bootloader();
+\Roots\bootloader()->boot();

closes #162

Base automatically changed from update-laravel to main January 31, 2022 06:00
@QWp6t QWp6t merged commit 00b84e4 into main Feb 6, 2022
@QWp6t QWp6t deleted the kernel-bootloader branch February 6, 2022 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: ExceptionHandler throws critical error in CLI while on production
1 participant