🧑💻 Translate template name if theme text domain can be loaded #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @retlehs! Just wondering if this might have a chance of making it into Acorn? If not - or if it's likely to take considerably longer - I'll start looking for an alternative approach 🙂 Not being able to translate template names is not a major issue by any means, but it does make things somewhat unintuitive for our content editors. Sorry for pinging you directly, by the way; not entirely sure what the process of handling PRs is like 🙏🙂 |
|
@teppokoivula Thanks so much for this PR! My apologies on how long it's taken me to get back to you. Finally got around to testing this |
retlehs
approved these changes
Feb 3, 2023
retlehs
changed the title
|
Awesome — thanks for merging! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for translating page/post template names in Blade templates, duplicating the translation behaviour from WP_Theme for FiltersTemplates.
Without this modification I couldn't find any truly sensible way to translate the visible labels for templates in the dropdown menu.