-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for compiling with GCC 15 (Fedora 42) #17455
Conversation
The function fchtak() is implemented earlier in the same file. There is therefore no need to declare the function later in the same file. The later declarations redefines the function with an empty parameter list, which conflicts with the original definition. The function stat() is defined by including <sys/stat.h>. The following daclaration redefines the function with an empty parameter list, which conflicts with the original definition.
Test Results 18 files 18 suites 3d 21h 22m 51s ⏱️ Results for commit 3357643. ♻️ This comment has been updated with latest results. |
Hi @ellert, thanks for the initiative! We have a few things to deal with:
Number 2 is a slow process, but we are working on it. So if you want to get out of this in a timely manner, I would propose to retain and clang-format the "conflicting functions" commit, and remove the LLVM commit. This way, we can merge this PR quickly, and we'll take care of the llvm business. Let us know what you think. |
@devajithvs FYI |
I ran git-clang-format as reqested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you!
The LLVM commits are on their way, and we'll take care of putting all of these changes into the next release.
I'm just waiting for one last CI job before merging.
This Pull request:
These changes make it possible to compile root 6.34.02 using gcc 15 on Fedora 42.
Also the following commits need to be backported from master:
commit 2884f67
commit cfc9221
... and the following commits from LLVM:
commit llvm/llvm-project@7e44305
commit llvm/llvm-project@7abf440 (see PR llvm/llvm-project#123320)