-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow geometry transparency at the volume level #13402
Merged
agheata
merged 3 commits into
root-project:master
from
MarkusFrankATcernch:volume_transparency
Aug 8, 2023
Merged
Allow geometry transparency at the volume level #13402
agheata
merged 3 commits into
root-project:master
from
MarkusFrankATcernch:volume_transparency
Aug 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can one of the admins verify this patch? |
agheata
requested changes
Aug 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Markus, we need to preserve backward compatibility, see my comment
agheata
reviewed
Aug 7, 2023
Co-authored-by: Andrei Gheata <andrei.gheata@cern.ch>
agheata
approved these changes
Aug 8, 2023
Failing tests are unrelated |
maksgraczyk
pushed a commit
to maksgraczyk/root
that referenced
this pull request
Jan 12, 2024
* Allow geometry transparency at the volume level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
This Pull request allows to set in TGeo the transparency of objects at the level of individual TGeoVolume instances.
ROOT was attributing the volume transparency to the material of the volume.
This is not always the desired behavior. The PR preserves the current functionality if the transparency level is not
explicitly set to the volume instance.
Improved functionality: If the transparency level is set directly to the volume instance, the volume transparency
takes precedence over the material transparency. The default behavior can be restored by setting a transparency
level of -1 to the volume.
Changes or fixes:
Improves the flexibility to set transparency to geometry volumes.
Checklist:
This PR fixes #