RPG refactored

Author: roma-derski

src/lesson5/task.js

@@ -1,59 +1,62 @@
-
+// Hero classes
 const heroClasses = {
 	warrior: { charClass: "Warrior",	life: 30,	damage: 4 },
 	rogue: { charClass: "Rogue", life: 25, damage: 3 },
 	sorcerer: {	charClass: "Sorcerer", life: 20, damage: 5 }
 };
 
-// Monsters classes and randomizer
+// Monsters classes
 const monsterClasses = {
 	zombie: { charClass: "Zombie", life: 8, damage: 4	},
 	skeleton: {	charClass: "Skeleton", life: 10, damage: 6 },
 	holem: { charClass: "Holem", life: 15, damage: 6 }
 };
 
-// Hero and Monsters constructors
+// Char
+const Char = function() {};
+
+Char.prototype.getName = function(){ 
+  return this.heroName || `I am ${this.charClass} I don\`t have name`; 
+};
+Char.prototype.getCharClass = function(){ return this.charClass; };
+
+Char.prototype.attack = function(enemy) {
+  let attacker, attacked;
+  if (this instanceof Hero) {
+    if (enemy instanceof Hero) return "I will attack only monsters";
+    attacker = 'Hero';
+    attacked = enemy.charClass;
+  }  
+  if (this instanceof Monster) {
+    if (enemy instanceof Monster) return "I will attack only Hero";
+    attacker = this.charClass;
+    attacked = 'Hero';
+  }
+  enemy.life = Math.max(enemy.life - this.damage, 0);
+  if (!enemy.life) return (`${attacker} attacked, ${attacked} killed`);
+  return (`${attacker} attacked, done ${this.damage} damage to ${attacked}`);
+};    
+  
+
+// Hero and Monster constructors
 const Hero = function(name, charClass) {
   if (heroClasses.hasOwnProperty(charClass)) {
     this.heroName = name;
     Object.assign(this, heroClasses[charClass]);
-    this.getName = function(){ return this.heroName; };
-    this.getCharClass = function(){ return this.charClass; };
   }
   else throw new Error("Incorrect character class provided");
 };
 
 const Monster = function(charClass) {
   if (monsterClasses.hasOwnProperty(charClass)) {
     Object.assign(this, monsterClasses[charClass]);
-    this.getName = function(){ return (`I am ${this.charClass} I don\`t have name`); };
-    this.getCharClass = function(){ return this.charClass; };
   }
   else throw new Error("Incorrect character class provided");
 };
 
-
-Hero.prototype.attack = function(enemy) {
-    if (enemy instanceof Hero) return "I will attack only monsters";
-    else {
-      enemy.life = Math.max(enemy.life - this.damage, 0);
-      if (!enemy.life) return (`Hero attacked, ${enemy.charClass} killed`);
-      return (`Hero attacked, done ${this.damage} damage to ${enemy.charClass}`);
-    }
-  };  
-  
-Monster.prototype.attack = function(enemy) {
-    if (enemy instanceof Monster) return "I will attack only Hero";
-    else {
-      enemy.life = Math.max(enemy.life - this.damage, 0);
-      if (!enemy.life) return (`${this.charClass} attacked, Hero killed`);
-      return (`${this.charClass} attacked, done ${this.damage} damage to ${enemy.charClass}`);
-    }
-  };
-
-// GENERAL_ATTACK_MESSAGE
-//    "CHARACTER_CLASS killed" - this action will kill target
-//    "done AMOUNT_OF_DAMAGE damage to CHARACTER_CLASS";
+Hero.prototype = new Char();
+Monster.prototype = new Char();
+//--------------------------------
 
 const statuses = {
 	idle      : "Idle",
@@ -66,9 +69,9 @@ const Game = function() {
   this.status = statuses.idle;
 };
 
-Object.defineProperty(Game.prototype, 'lives', {
+Object.defineProperty(Game.prototype, 'monstersAlive', {
   get: function() {
-    return this.monsters[0].life + this.monsters[1].life;
+    return this.monsters.some(monster => monster.life > 0);
   }
 });
 
@@ -78,7 +81,7 @@ Game.prototype.addHero = function(hero) {
   else if (this.hero) throw new Error ("Only one hero can exist");
   else {
     this.hero = hero;
-    return ("Hero created, welcome %s", this.hero.heroName);
+    return (`Hero created, welcome ${this.hero.heroName}`);
   }
 };
 
@@ -110,7 +113,7 @@ Game.prototype.finishJourney = function() {
     this.status = statuses.finished;
     return "The Game is finished. Hero is dead :(";
   }
-  else if (this.monsters[0].life + this.monsters[1].life === 0) {
+  else if (!this.monstersAlive) {
     return "The Game is finished. Monsters are dead. Congratulations";
   }
   else return "Don`t stop. Some monsters are still alive. Kill`em all";
@@ -121,32 +124,45 @@ Game.prototype.fight = function() {
     throw new Error("Begin your journey to start fighting monsters");
   }
 
+  if (!this.hero.life || !this.monstersAlive) return this.finishJourney();
+  
   let currentMonster;
-  if (this.monsters[0].life) currentMonster = this.monsters[0];
-  else if (this.monsters[1].life) currentMonster = this.monsters[1];
+  for (let m of this.monsters) {
+    if (m.life) {
+      currentMonster = m;
+      break;
+    } 
+  }
 
   while (this.hero.life && currentMonster.life) {
     this.hero.attack(currentMonster);
     if (currentMonster.life) currentMonster.attack(this.hero);
   }
-  if (!this.hero.life) return "Monster win";
-  else if (!currentMonster.life) return "Hero win";
+  if (!this.hero.life) {
+    this.status = statuses.finished;
+    return "Monster win";
+  }
+  else if (!this.monstersAlive) {
+    this.status = statuses.finished;
+    return "Hero win";
+  }
+  return "Hero win";
 };
 
 
 /* Game Population mechanism should go below */
 
 Game.prototype.populate = function() {
   const heroName = prompt('Name your Hero:', 'Chuck Norris');
-  const heroClass = prompt('What is your Hero?', 'warrior | rogue | sorcerer | random').toLowerCase().trim();
+  const heroClass = prompt('What is your Hero?', 'warrior | rogue | sorcerer | random').trim();
   if (heroClass === 'random') this.addRandomHero(heroName);
   else {
     const theHero = new Hero(heroName, heroClass);
     this.addHero(theHero);
   }
 
-  while (this.monsters.length < 2) {
-    const monsterClass = prompt(`What is your Monster ${this.monsters.length+1}?`, 'zombie | skeleton | holem | random').toLowerCase().trim();
+  while (this.monsters.length < Game.maxMonsters) {
+    const monsterClass = prompt(`What is your Monster ${this.monsters.length+1}?`, 'zombie | skeleton | holem | random').trim();
     if (monsterClass === 'random') this.addRandomMonster();
     else {
       const theMonster = new Monster(monsterClass);