Skip to content

Get rid of 'eval' in the definition of English #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
roelvandijk opened this issue Feb 13, 2012 · 0 comments
Open

Get rid of 'eval' in the definition of English #6

roelvandijk opened this issue Feb 13, 2012 · 0 comments
Assignees
@roelvandijk

Comments

@roelvandijk
Copy link
Owner

The definition of English (Text.Numeral.Language.EN) uses an ugly hack to decide whether to put "and" between numerals being added. This hack depends on evaluating the Integer value of the expression context.

We should replace this hack with proper pattern-matching logic and guards.
@ghost ghost assigned roelvandijk Feb 13, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roelvandijk roelvandijk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@roelvandijk