Disable development NoEvalCop for load-time eval calls

rmosolgo · rmosolgo · commit 4deb98d4884f · 2025-03-05T14:59:05.000-05:00
diff --git a/cop/development/no_eval_cop.rb b/cop/development/no_eval_cop.rb
@@ -4,7 +4,7 @@
 module Cop
   module Development
     class NoEvalCop < RuboCop::Cop::Base
-      MSG_TEMPLATE = "Don't use `%{eval_method_name}` which accept strings and may result in unexpected code being generated. Use `%{exec_method_name}` instead, and pass a block."
+      MSG_TEMPLATE = "Don't use `%{eval_method_name}` which accepts strings and may result evaluating unexpected code. Use `%{exec_method_name}` instead, and pass a block."
 
       def on_send(node)
         case node.method_name
diff --git a/lib/graphql/language/nodes.rb b/lib/graphql/language/nodes.rb
@@ -138,6 +138,8 @@ def merge!(new_options)
         end
 
         class << self
+          # rubocop:disable Development/NoEvalCop This eval takes static inputs at load-time
+
           # Add a default `#visit_method` and `#children_method_name` using the class name
           def inherited(child_class)
             super
@@ -294,6 +296,8 @@ def self.from_a(filename, line, col, #{(scalar_method_names + @children_methods.
                   self.new(filename: filename, line: line, col: col, #{keywords.join(", ")})
                 end
               RUBY
+
+              # rubocop:enable Development/NoEvalCop
             end
           end
         end
diff --git a/lib/graphql/language/static_visitor.rb b/lib/graphql/language/static_visitor.rb
@@ -21,6 +21,7 @@ def visit
           @document
         end
       end
+      # rubocop:disable Development/NoEvalCop This eval takes static inputs at load-time
 
       # We don't use `alias` here because it breaks `super`
       def self.make_visit_methods(ast_node_class)
@@ -55,6 +56,48 @@ def #{node_method}(node, parent)
         RUBY
       end
 
+      [
+        Language::Nodes::Argument,
+        Language::Nodes::Directive,
+        Language::Nodes::DirectiveDefinition,
+        Language::Nodes::DirectiveLocation,
+        Language::Nodes::Document,
+        Language::Nodes::Enum,
+        Language::Nodes::EnumTypeDefinition,
+        Language::Nodes::EnumTypeExtension,
+        Language::Nodes::EnumValueDefinition,
+        Language::Nodes::Field,
+        Language::Nodes::FieldDefinition,
+        Language::Nodes::FragmentDefinition,
+        Language::Nodes::FragmentSpread,
+        Language::Nodes::InlineFragment,
+        Language::Nodes::InputObject,
+        Language::Nodes::InputObjectTypeDefinition,
+        Language::Nodes::InputObjectTypeExtension,
+        Language::Nodes::InputValueDefinition,
+        Language::Nodes::InterfaceTypeDefinition,
+        Language::Nodes::InterfaceTypeExtension,
+        Language::Nodes::ListType,
+        Language::Nodes::NonNullType,
+        Language::Nodes::NullValue,
+        Language::Nodes::ObjectTypeDefinition,
+        Language::Nodes::ObjectTypeExtension,
+        Language::Nodes::OperationDefinition,
+        Language::Nodes::ScalarTypeDefinition,
+        Language::Nodes::ScalarTypeExtension,
+        Language::Nodes::SchemaDefinition,
+        Language::Nodes::SchemaExtension,
+        Language::Nodes::TypeName,
+        Language::Nodes::UnionTypeDefinition,
+        Language::Nodes::UnionTypeExtension,
+        Language::Nodes::VariableDefinition,
+        Language::Nodes::VariableIdentifier,
+      ].each do |ast_node_class|
+        make_visit_methods(ast_node_class)
+      end
+
+      # rubocop:disable Development/NoEvalCop
+
       def on_document_children(document_node)
         document_node.children.each do |child_node|
           visit_method = child_node.visit_method
@@ -122,46 +165,6 @@ def on_argument_children(new_node)
           end
         end
       end
-
-      [
-        Language::Nodes::Argument,
-        Language::Nodes::Directive,
-        Language::Nodes::DirectiveDefinition,
-        Language::Nodes::DirectiveLocation,
-        Language::Nodes::Document,
-        Language::Nodes::Enum,
-        Language::Nodes::EnumTypeDefinition,
-        Language::Nodes::EnumTypeExtension,
-        Language::Nodes::EnumValueDefinition,
-        Language::Nodes::Field,
-        Language::Nodes::FieldDefinition,
-        Language::Nodes::FragmentDefinition,
-        Language::Nodes::FragmentSpread,
-        Language::Nodes::InlineFragment,
-        Language::Nodes::InputObject,
-        Language::Nodes::InputObjectTypeDefinition,
-        Language::Nodes::InputObjectTypeExtension,
-        Language::Nodes::InputValueDefinition,
-        Language::Nodes::InterfaceTypeDefinition,
-        Language::Nodes::InterfaceTypeExtension,
-        Language::Nodes::ListType,
-        Language::Nodes::NonNullType,
-        Language::Nodes::NullValue,
-        Language::Nodes::ObjectTypeDefinition,
-        Language::Nodes::ObjectTypeExtension,
-        Language::Nodes::OperationDefinition,
-        Language::Nodes::ScalarTypeDefinition,
-        Language::Nodes::ScalarTypeExtension,
-        Language::Nodes::SchemaDefinition,
-        Language::Nodes::SchemaExtension,
-        Language::Nodes::TypeName,
-        Language::Nodes::UnionTypeDefinition,
-        Language::Nodes::UnionTypeExtension,
-        Language::Nodes::VariableDefinition,
-        Language::Nodes::VariableIdentifier,
-      ].each do |ast_node_class|
-        make_visit_methods(ast_node_class)
-      end
     end
   end
 end
diff --git a/lib/graphql/language/visitor.rb b/lib/graphql/language/visitor.rb
@@ -60,6 +60,7 @@ def visit
           @document
         end
       end
+      # rubocop:disable Development/NoEvalCop This eval takes static inputs at load-time
 
       # We don't use `alias` here because it breaks `super`
       def self.make_visit_methods(ast_node_class)
@@ -116,6 +117,48 @@ def #{node_method}_with_modifications(node, parent)
         RUBY
       end
 
+      [
+        Language::Nodes::Argument,
+        Language::Nodes::Directive,
+        Language::Nodes::DirectiveDefinition,
+        Language::Nodes::DirectiveLocation,
+        Language::Nodes::Document,
+        Language::Nodes::Enum,
+        Language::Nodes::EnumTypeDefinition,
+        Language::Nodes::EnumTypeExtension,
+        Language::Nodes::EnumValueDefinition,
+        Language::Nodes::Field,
+        Language::Nodes::FieldDefinition,
+        Language::Nodes::FragmentDefinition,
+        Language::Nodes::FragmentSpread,
+        Language::Nodes::InlineFragment,
+        Language::Nodes::InputObject,
+        Language::Nodes::InputObjectTypeDefinition,
+        Language::Nodes::InputObjectTypeExtension,
+        Language::Nodes::InputValueDefinition,
+        Language::Nodes::InterfaceTypeDefinition,
+        Language::Nodes::InterfaceTypeExtension,
+        Language::Nodes::ListType,
+        Language::Nodes::NonNullType,
+        Language::Nodes::NullValue,
+        Language::Nodes::ObjectTypeDefinition,
+        Language::Nodes::ObjectTypeExtension,
+        Language::Nodes::OperationDefinition,
+        Language::Nodes::ScalarTypeDefinition,
+        Language::Nodes::ScalarTypeExtension,
+        Language::Nodes::SchemaDefinition,
+        Language::Nodes::SchemaExtension,
+        Language::Nodes::TypeName,
+        Language::Nodes::UnionTypeDefinition,
+        Language::Nodes::UnionTypeExtension,
+        Language::Nodes::VariableDefinition,
+        Language::Nodes::VariableIdentifier,
+      ].each do |ast_node_class|
+        make_visit_methods(ast_node_class)
+      end
+
+      # rubocop:enable Development/NoEvalCop
+
       def on_document_children(document_node)
         new_node = document_node
         document_node.children.each do |child_node|
@@ -216,46 +259,6 @@ def on_argument_children(new_node)
         new_node
       end
 
-      [
-        Language::Nodes::Argument,
-        Language::Nodes::Directive,
-        Language::Nodes::DirectiveDefinition,
-        Language::Nodes::DirectiveLocation,
-        Language::Nodes::Document,
-        Language::Nodes::Enum,
-        Language::Nodes::EnumTypeDefinition,
-        Language::Nodes::EnumTypeExtension,
-        Language::Nodes::EnumValueDefinition,
-        Language::Nodes::Field,
-        Language::Nodes::FieldDefinition,
-        Language::Nodes::FragmentDefinition,
-        Language::Nodes::FragmentSpread,
-        Language::Nodes::InlineFragment,
-        Language::Nodes::InputObject,
-        Language::Nodes::InputObjectTypeDefinition,
-        Language::Nodes::InputObjectTypeExtension,
-        Language::Nodes::InputValueDefinition,
-        Language::Nodes::InterfaceTypeDefinition,
-        Language::Nodes::InterfaceTypeExtension,
-        Language::Nodes::ListType,
-        Language::Nodes::NonNullType,
-        Language::Nodes::NullValue,
-        Language::Nodes::ObjectTypeDefinition,
-        Language::Nodes::ObjectTypeExtension,
-        Language::Nodes::OperationDefinition,
-        Language::Nodes::ScalarTypeDefinition,
-        Language::Nodes::ScalarTypeExtension,
-        Language::Nodes::SchemaDefinition,
-        Language::Nodes::SchemaExtension,
-        Language::Nodes::TypeName,
-        Language::Nodes::UnionTypeDefinition,
-        Language::Nodes::UnionTypeExtension,
-        Language::Nodes::VariableDefinition,
-        Language::Nodes::VariableIdentifier,
-      ].each do |ast_node_class|
-        make_visit_methods(ast_node_class)
-      end
-
       private
 
       def apply_modifications(node, parent, new_node_and_new_parent)
diff --git a/lib/graphql/schema/build_from_definition.rb b/lib/graphql/schema/build_from_definition.rb
@@ -451,17 +451,18 @@ def build_fields(owner, field_definitions, type_resolver, default_resolve:)
 
             # Don't do this for interfaces
             if default_resolve
-              owner.class_eval <<-RUBY, __FILE__, __LINE__
-                # frozen_string_literal: true
-                def #{resolve_method_name}(**args)
-                  field_instance = self.class.get_field("#{field_definition.name}")
-                  context.schema.definition_default_resolve.call(self.class, field_instance, object, args, context)
-                end
-              RUBY
+              define_field_resolve_method(owner, resolve_method_name, field_definition.name)
             end
           end
         end
 
+        def define_field_resolve_method(owner, method_name, field_name)
+          owner.define_method(method_name) { |**args|
+            field_instance = self.class.get_field(field_name)
+            context.schema.definition_default_resolve.call(self.class, field_instance, object, args, context)
+          }
+        end
+
         def build_resolve_type(lookup_hash, directives, missing_type_handler)
           resolve_type_proc = nil
           resolve_type_proc = ->(ast_node) {
diff --git a/lib/graphql/schema/input_object.rb b/lib/graphql/schema/input_object.rb
@@ -44,6 +44,19 @@ def to_hash
         to_h
       end
 
+<<<<<<< HEAD
+=======
+      def deconstruct_keys(keys = nil)
+        if keys.nil?
+          @ruby_style_hash
+        else
+          new_h = {}
+          keys.each { |k| @ruby_style_hash.key?(k) && new_h[k] = @ruby_style_hash[k] }
+          new_h
+        end
+      end
+
+>>>>>>> d85e69690f (Disable development NoEvalCop for load-time eval calls)
       def prepare
         if @context
           object = @context[:current_object]
@@ -131,12 +144,7 @@ def argument(*args, **kwargs, &block)
             end
           end
           # Add a method access
-          method_name = argument_defn.keyword
-          class_eval <<-RUBY, __FILE__, __LINE__
-            def #{method_name}
-              self[#{method_name.inspect}]
-            end
-          RUBY
+          define_accessor_method(argument_defn.keyword)
           argument_defn
         end
 
@@ -242,6 +250,13 @@ def coerce_result(value, ctx)
 
           result
         end
+
+        private
+
+        def define_accessor_method(method_name)
+          define_method(method_name) { self[method_name] }
+          alias_method(method_name, method_name)
+        end
       end
 
       private
diff --git a/lib/graphql/tracing/appoptics_trace.rb b/lib/graphql/tracing/appoptics_trace.rb
@@ -28,6 +28,8 @@ def self.version
         Gem::Version.new('1.0.0')
       end
 
+      # rubocop:disable Development/NoEvalCop This eval takes static inputs at load-time
+
       [
         'lex',
         'parse',
@@ -55,6 +57,8 @@ def #{trace_method}(**data)
         RUBY
       end
 
+      # rubocop:enable Development/NoEvalCop
+
       def execute_field(query:, field:, ast_node:, arguments:, object:)
         return_type = field.type.unwrap
         trace_field = if return_type.kind.scalar? || return_type.kind.enum?
diff --git a/lib/graphql/tracing/appsignal_trace.rb b/lib/graphql/tracing/appsignal_trace.rb
@@ -13,6 +13,8 @@ def initialize(set_action_name: false, **rest)
         super
       end
 
+      # rubocop:disable Development/NoEvalCop This eval takes static inputs at load-time
+
       {
         "lex" => "lex.graphql",
         "parse" => "parse.graphql",
@@ -43,6 +45,8 @@ def #{trace_method}(**data)
         RUBY
       end
 
+      # rubocop:enable Development/NoEvalCop
+
       def platform_execute_field(platform_key)
         Appsignal.instrument(platform_key) do
           yield
diff --git a/lib/graphql/tracing/data_dog_trace.rb b/lib/graphql/tracing/data_dog_trace.rb
@@ -20,6 +20,8 @@ def initialize(tracer: nil, analytics_enabled: false, analytics_sample_rate: 1.0
         super
       end
 
+      # rubocop:disable Development/NoEvalCop This eval takes static inputs at load-time
+
       {
         'lex' => 'lex.graphql',
         'parse' => 'parse.graphql',
@@ -69,6 +71,8 @@ def #{trace_method}(**data)
         RUBY
       end
 
+      # rubocop:enable Development/NoEvalCop
+
       def execute_field_span(span_key, query, field, ast_node, arguments, object)
         return_type = field.type.unwrap
         trace_field = if return_type.kind.scalar? || return_type.kind.enum?
diff --git a/lib/graphql/tracing/notifications_trace.rb b/lib/graphql/tracing/notifications_trace.rb
@@ -16,6 +16,8 @@ def initialize(engine:, **rest)
         super
       end
 
+      # rubocop:disable Development/NoEvalCop This eval takes static inputs at load-time
+
       {
         "lex" => "lex.graphql",
         "parse" => "parse.graphql",
@@ -39,6 +41,8 @@ def #{trace_method}(**metadata, &blk)
         RUBY
       end
 
+      # rubocop:enable Development/NoEvalCop
+
       include PlatformTrace
     end
   end
diff --git a/lib/graphql/tracing/platform_trace.rb b/lib/graphql/tracing/platform_trace.rb
@@ -39,6 +39,9 @@ def self.included(child_class)
           include(BaseKeyCache)
         }
         child_class.const_set(:KeyCache, key_methods_class)
+
+        # rubocop:disable Development/NoEvalCop This eval takes static inputs at load-time
+
         [:execute_field, :execute_field_lazy].each do |field_trace_method|
           if !child_class.method_defined?(field_trace_method)
             child_class.module_eval <<-RUBY, __FILE__, __LINE__
@@ -91,6 +94,8 @@ def #{rt_trace_method}(query:, type:, object:)
               end
             RUBY
           end
+
+          # rubocop:enable Development/NoEvalCop
         end
       end
 
diff --git a/lib/graphql/tracing/prometheus_trace.rb b/lib/graphql/tracing/prometheus_trace.rb
diff --git a/lib/graphql/tracing/scout_trace.rb b/lib/graphql/tracing/scout_trace.rb
diff --git a/lib/graphql/tracing/statsd_trace.rb b/lib/graphql/tracing/statsd_trace.rb
