Skip to content

Commit 6313a74

Browse files
authored
[CI/CD] Fix action build (#258)
* fix action build * align coding style * remove finished TODOs * remove finished TODOs
1 parent b3ac614 commit 6313a74

File tree

2 files changed

+8
-10
lines changed

2 files changed

+8
-10
lines changed

TODO.rst

-6
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,11 @@
11
TODO
22
====
33

4-
* Test on different redis versions.
54
* Add SCRAPY_JOB global support (jobs sharing same SCRAPY_JOB share same queues).
65
* Use a spider middleware instead of spider mixin. This will avoid the spider
76
idle signal hack.
8-
* Sync with latest scrapy code (i.e. scheduler, rfpdupefilter, etc).
97
* Allow to use pubsub whenever appropriate.
10-
* Generalize queue clases (i.e.: LifoQueue, FifoQueue, PriorityQueue,
11-
PubsubQueue), allow custom serializers, use enqueue, dequeue methods.
128
* Move example project to its own repository. Include different crawling use
139
cases (i.e.: producer/consumer).
1410
* Add pyrebloom dupefilter.
1511
* Warn and pass unserializable requests.
16-
* Drop official support for Scrapy 1.0. It is enough to support current and previous
17-
scrapy version.

tox.ini

+8-4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
[tox]
2-
envlist = security,flake8,py{37,38,39,310}-scrapy{18,25,26}-redis{40,41,42}
2+
envlist = security,flake8,py{37,38,39,310}-scrapy{25,26}-redis{40,41,42}
33
minversion = 1.7.0
44

55
[base]
@@ -20,7 +20,6 @@ deps =
2020
pytest
2121
pytest-cov
2222
commands =
23-
scrapy18: pip install scrapy==1.8.2
2423
scrapy25: pip install scrapy==2.5.1
2524
scrapy26: pip install scrapy==2.6.1
2625
redis40: pip install redis==4.0.2
@@ -35,7 +34,7 @@ deps =
3534
{[base]deps}
3635
flake8 # https://github.com/tholo/pytest-flake8/issues/81
3736
commands =
38-
flake8 docs tests
37+
flake8 docs/ tests/
3938

4039
[testenv:security]
4140
basepython = python3.10
@@ -65,4 +64,9 @@ commands =
6564
pip install .
6665
python -m pytest --cov-report term --cov=scrapy_redis
6766

68-
# TODO: build docs
67+
[testenv:build]
68+
basepython=python3.10
69+
deps =
70+
{[base]deps}
71+
commands =
72+
pip install .

0 commit comments

Comments
 (0)