-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce adaptive_parallelism_strategy
#20589
Open
shanicky
wants to merge
9
commits into
main
Choose a base branch
from
peng/adaptive-strategy-enum
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccfb7ab
to
52495c3
Compare
yezizp2012
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Please mark it user-facing and add some necessary release notes.
87a72df
to
5350a1c
Compare
…parallelism adjustment
…mStrategy, apply in DDL and Scale Signed-off-by: Shanicky Chen <peng@risingwave-labs.com>
… Improve error handling Signed-off-by: Shanicky Chen <peng@risingwave-labs.com>
… alteration in `scale` tests
…, default is "Auto"
… logic; expand test suite
…`tests.system_param` module.
Signed-off-by: Shanicky Chen <peng@risingwave-labs.com>
5350a1c
to
1652e07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR adds a system parameter called
adaptive_parallelism_strategy
to control the behavior of jobs when they are of the adaptive type, including options likeAuto/Full
,Bounded(n)
, andRatio(r)
. These can be accessed in real-time to manage scheduling and rescheduling. Modifying this will send a local notification to inform the scale controller.Checklist
Documentation
Release note
This PR adds behavior for jobs with adaptive parallelism.
Full
, the job will use all available parallelism;Bounded(n)
, the maximum parallelism is limited ton
;Ratio(r)
, the actual available parallelism will be multiplied by r (rounded down);Keep in mind that all parallelism is still subject to the limits of max parallelism and resource groups.
Additionally, the command
alter system set adaptive_parallelism_strategy
can be used to modify this parameter, and it will update jobs in batches in the background.