Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimizer: merge StreamIndexScan into StreamTableScan #8534

Closed
BugenZhao opened this issue Mar 14, 2023 · 4 comments
Closed

optimizer: merge StreamIndexScan into StreamTableScan #8534

BugenZhao opened this issue Mar 14, 2023 · 4 comments
Assignees
Labels
Milestone

Comments

@BugenZhao
Copy link
Member

BugenZhao commented Mar 14, 2023

StreamIndexScan was introduced for delta-join in #2107. But as we refactor it, it seems there's not much difference in the implementation between IndexScan and TableScan, especially after we introduce the ChainType. Should we merge them into one to avoid code duplication?

cc @chenzl25 @st1page @fuyufjh

@github-actions github-actions bot added this to the release-0.1.18 milestone Mar 14, 2023
@fuyufjh
Copy link
Member

fuyufjh commented Mar 14, 2023

Sounds reasonable. 🤔 What's the initial motivation of introducing StreamIndexScan?

@chenzl25
Copy link
Contributor

Yes, I think they have no essential difference.

@chenzl25
Copy link
Contributor

Sounds reasonable. 🤔 What's the initial motivation of introducing StreamIndexScan?

IMO, creating a delta join on existing mv just needs to consume existing data from one data flow. FYI, N way delta join has N
separate data flows. Previously, it is likely that the index scan use a different strategy to consume the existing data.

@y-wei
Copy link
Contributor

y-wei commented Mar 17, 2023

close as completed #8567

@y-wei y-wei closed this as completed Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants