Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: merge identical agg calls in a streaming query #8101

Closed
2 tasks done
Tracked by #7289
stdrc opened this issue Feb 21, 2023 · 0 comments
Closed
2 tasks done
Tracked by #7289

perf: merge identical agg calls in a streaming query #8101

stdrc opened this issue Feb 21, 2023 · 0 comments
Assignees
Milestone

Comments

@stdrc
Copy link
Member

stdrc commented Feb 21, 2023

This can increase performance in two cases:

  1. select sum(a), avg(a), ... (perf: nexmark q17 #7351 (comment))
  2. select count(*), ..., at the same time we internally insert a count(*) to the beginning, then we'll have plan like this:
    └─StreamAppendOnlyHashAgg { group_key: [...], aggs: [count, count, ...] }
    

Seems these two cases need different optimization logic, so track it here:

@stdrc stdrc self-assigned this Feb 21, 2023
@github-actions github-actions bot added this to the release-0.1.18 milestone Feb 21, 2023
@stdrc stdrc closed this as completed Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant