Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: optimize to_char #7924

Closed
Tracked by #7289
kwannoel opened this issue Feb 14, 2023 · 4 comments
Closed
Tracked by #7289

perf: optimize to_char #7924

kwannoel opened this issue Feb 14, 2023 · 4 comments
Assignees
Milestone

Comments

@kwannoel
Copy link
Contributor

kwannoel commented Feb 14, 2023

see #7351 (comment).

  1. Bench build_to_char_const_tmpl w/o template string. I think what is currently benched includes compilation of template str.
  2. Use rust date time formatting as baseline / find some other suitable baseline.
  3. Bench date_time::date : perf: nexmark q17 #7351 (comment)
  4. Precompute and store in executor the tmpl pattern matching object. This is done already.
@kwannoel kwannoel self-assigned this Feb 14, 2023
@github-actions github-actions bot added this to the release-0.1.18 milestone Feb 14, 2023
@kwannoel

This comment was marked as outdated.

@kwannoel

This comment was marked as outdated.

@kwannoel kwannoel closed this as not planned Won't fix, can't repro, duplicate, stale Feb 14, 2023
@kwannoel kwannoel reopened this Feb 15, 2023
@lmatz
Copy link
Contributor

lmatz commented Mar 14, 2023

suspect simply because chrono::format::Item is not efficient enough
https://github.com/chronotope/chrono#:~:text=(while%20not%20being%20the%20primary%20goal)%20reasonably%20efficient

@kwannoel kwannoel modified the milestones: release-0.18, release-0.19 Mar 17, 2023
@kwannoel
Copy link
Contributor Author

kwannoel commented Mar 20, 2023

Update, to_char is not really a performance bottleneck, only ~1% is attributed to it in q17.

Screenshot 2023-03-20 at 12 17 09 PM

However, to_char does lead to things being represented as varchar, which is the real cost.

Opening a separate issue to track.

@kwannoel kwannoel closed this as not planned Won't fix, can't repro, duplicate, stale Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants