Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve compaction testing #10636

Open
hzxa21 opened this issue Jun 28, 2023 · 4 comments
Open

Improve compaction testing #10636

hzxa21 opened this issue Jun 28, 2023 · 4 comments
Assignees

Comments

@hzxa21
Copy link
Collaborator

hzxa21 commented Jun 28, 2023

Recently we have witnessed multiple issues related to compaction/compactor:

These issues are related to excessive compaction load, compactor failure and compaction group split. Some of these issues are corner cases that can hardly be caught while others are not. Although we have compaction running in different testing pipelines (longevity, perf, main-cron, ut, e2e) to cover the basic cases, we have low coverage on these scenarios.

Some ideas:

  • [Enable injecting compactor/meta failure and restarts in chaos-mesh test
  • [Put more loads on L0 in the testing pipeline (originally proposed by @Li0k)
    • We can leverge deterministic compaction test to generate more L0 SSTs to reply before triggering compaction.
    • We can shutdown all compactors in the longevity/chaos-mesh pipeline and let L0 SSTs to accumulate for a while before restarting the compactors.
  • Can we also test compaction group split via the deterministic compaction test tool?

Open to other ideas as well.

@github-actions github-actions bot added this to the release-0.20 milestone Jun 28, 2023
@hzxa21
Copy link
Collaborator Author

hzxa21 commented Jun 29, 2023

cc @Li0k @Little-Wallace

@fuyufjh fuyufjh removed this from the release-1.0 milestone Aug 8, 2023
@fuyufjh
Copy link
Member

fuyufjh commented Aug 8, 2023

Hey, any updates on this?

@Li0k
Copy link
Contributor

Li0k commented Aug 9, 2023

Hey, any updates on this?

No progress so far

Copy link
Contributor

github-actions bot commented Jul 3, 2024

This issue has been open for 60 days with no activity.

If you think it is still relevant today, and needs to be done in the near future, you can comment to update the status, or just manually remove the no-issue-activity label.

You can also confidently close this issue as not planned to keep our backlog clean.
Don't worry if you think the issue is still valuable to continue in the future.
It's searchable and can be reopened when it's time. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants