Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SELECT * EXCEPT in sqlsmith #10516

Open
Tracked by #7934
wugouzi opened this issue Jun 25, 2023 · 5 comments
Open
Tracked by #7934

Support SELECT * EXCEPT in sqlsmith #10516

wugouzi opened this issue Jun 25, 2023 · 5 comments

Comments

@wugouzi
Copy link
Contributor

wugouzi commented Jun 25, 2023

We added SELECT * EXCEPT (columns) in #10438, but the corresponding sqlsmith test are not added.

The reason is that currently, sqlsmith does not track the generated columns from certain functions over tables (e.g., window_start from tumble). But select * or select * except (...) will introduce those columns unintentionally which would lead to incorrect sqls. Example:

CREATE MATERIALIZED VIEW m1 AS SELECT * FROM tumble(bid, bid.date_time, INTERVAL '44') AS tumble_0;

SELECT * FROM tumble(m1, m1.date_time, INTERVAL '7') AS tumble_1:
@kwannoel
Copy link
Contributor

Seems like a good target for sqlsmith tutorial, as a replacement for #10327, since eowc maybe a little complicated for sqlsmith tutorial.

@fuyufjh
Copy link
Member

fuyufjh commented Jul 18, 2023

@wugouzi Can you please do it? The feature developer is supposed to complete the sqlsmith tests.

@wugouzi
Copy link
Contributor Author

wugouzi commented Jul 18, 2023

I may not be free until finishing the refactoring of source parser. I could do it when I have time. Also may need review for this #10723.

Need to wait for #11013

@fuyufjh fuyufjh removed this from the release-1.0 milestone Aug 8, 2023
@kwannoel
Copy link
Contributor

kwannoel commented Aug 17, 2023

I may not be free until finishing the refactoring of source parser. I could do it when I have time. Also may need review for this #10723.

Need to wait for #11013

Sorry for delay. #11013 has been completed. #11013, I think this issue may proceed.

Copy link
Contributor

github-actions bot commented Jul 3, 2024

This issue has been open for 60 days with no activity.

If you think it is still relevant today, and needs to be done in the near future, you can comment to update the status, or just manually remove the no-issue-activity label.

You can also confidently close this issue as not planned to keep our backlog clean.
Don't worry if you think the issue is still valuable to continue in the future.
It's searchable and can be reopened when it's time. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants