fix(ascii_composer): support key binding Shift+space in ascii mode

lotem · lotem · commit 707738900168 · 2017-10-16T23:40:14.000+08:00
diff --git a/src/rime/gear/ascii_composer.cc b/src/rime/gear/ascii_composer.cc
@@ -107,8 +107,9 @@ ProcessResult AsciiComposer::ProcessKeyEvent(const KeyEvent& key_event) {
   }
   // other keys
   shift_key_pressed_ = ctrl_key_pressed_ = false;
-  if (key_event.ctrl()) {
-    return kNoop;  // possible key binding Control+x
+  // possible key binding: Control+x, Shift+space
+  if (key_event.ctrl() || (key_event.shift() && ch == XK_space)) {
+    return kNoop;
   }
   Context* ctx = engine_->context();
   bool ascii_mode = ctx->get_option("ascii_mode");

Original file line number	Diff line number	Diff line change
`@@ -107,8 +107,9 @@ ProcessResult AsciiComposer::ProcessKeyEvent(const KeyEvent& key_event) {`
`107`	`107`	`}`
`108`	`108`	`// other keys`
`109`	`109`	`shift_key_pressed_ = ctrl_key_pressed_ = false;`
`110`		`- if (key_event.ctrl()) {`
`111`		`- return kNoop; // possible key binding Control+x`
	`110`	`+ // possible key binding: Control+x, Shift+space`
	`111`	`+ if (key_event.ctrl() \|\| (key_event.shift() && ch == XK_space)) {`
	`112`	`+ return kNoop;`
`112`	`113`	`}`
`113`	`114`	`Context* ctx = engine_->context();`
`114`	`115`	`bool ascii_mode = ctx->get_option("ascii_mode");`