Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iphlpapi support #802

Merged
merged 26 commits into from
Apr 24, 2020
Merged

iphlpapi support #802

merged 26 commits into from
Apr 24, 2020

Conversation

hankbao
Copy link
Contributor

@hankbao hankbao commented Aug 26, 2019

It looks like the #772 has been stalled for a while. So I'd like to give it a try.

@hankbao hankbao changed the title iphlpapi support [WIP] iphlpapi support Aug 26, 2019
@hankbao hankbao changed the title [WIP] iphlpapi support iphlpapi support Aug 26, 2019
@hankbao
Copy link
Contributor Author

hankbao commented Aug 27, 2019

@retep998 Hi, I've fixed a bunch of issues and added necessary tests. Now all tests passed. Please take some time to review this PR. Thanks.

@retep998 retep998 added the waiting on review Waiting for a reviewer to review the PR label Aug 28, 2019
retep998
retep998 requested changes Aug 28, 2019
View reviewed changes
@retep998 retep998 added waiting on author Waiting for author to update PR based on feedback and removed waiting on review Waiting for a reviewer to review the PR labels Aug 28, 2019
This was referenced Aug 28, 2019
Closed
Closed
Closed
@hankbao
Copy link
Contributor Author

hankbao commented Aug 28, 2019

@retep998 Please continue your review. Thanks.

@retep998 retep998 added waiting on review Waiting for a reviewer to review the PR and removed waiting on author Waiting for author to update PR based on feedback labels Aug 28, 2019
@svartalf svartalf mentioned this pull request Aug 31, 2019
Open
@firestack firestack mentioned this pull request Sep 24, 2019
Open
@TyPR124 TyPR124 mentioned this pull request Oct 30, 2019
Closed
@TyPR124
Copy link

TyPR124 commented Oct 30, 2019

Is there anything here that still needs changed/fixed here, or just waiting on review?

Also I am not seeing the ICMP API in here. Unless someone else plans to or has already done this, I can work on that once this is merged.

@hankbao
Copy link
Contributor Author

hankbao commented Oct 30, 2019

Still waiting for this PR to get reviewed.

@TyPR124 TyPR124 mentioned this pull request Nov 18, 2019
Open
@hankbao hankbao requested a review from retep998 November 26, 2019 09:28
@ErichDonGubler
Copy link

@hankbao @retep998: Anything stopping this from getting merged? I'd really like to see heim-rs/heim#29 resolved and am not sure how to help!

@hankbao
Copy link
Contributor Author

hankbao commented Jan 13, 2020

Need to get reviewed by @retep998

@GuillaumeGomez
Copy link
Contributor

@retep998 Need a hand?

@retep998
Copy link
Owner

retep998 commented Feb 2, 2020

@GuillaumeGomez I've been far too busy to give winapi the attention it deserves, so I'd be happy to have some help.

@GuillaumeGomez
Copy link
Contributor

Ok, let's talk about it on IRC whenever we're both present at the same time!

@vkrasnov
Copy link

Hi all, this would be very useful to me. I can help reviewing if that helps.

@yuguorui
Copy link

Please...

retep998
retep998 requested changes Mar 25, 2020
View reviewed changes
Copy link
Owner

@retep998 retep998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long to get to this.

retep998
retep998 reviewed Mar 25, 2020
View reviewed changes
@hankbao hankbao requested a review from retep998 April 6, 2020 18:37
BlackHoleFox and others added 26 commits April 7, 2020 14:48
@BlackHoleFox @hankbao
Iphlpapi addition
8b193f1
@hankbao
comply to pr comments in retep998#772
0fd9b46
@hankbao
replace SIZEOF_* macros with functions
31f5abc
@hankbao
feat: netioapi support
6fac11e
@hankbao
fix typo & improve code
a9f1b66
@hankbao
avoid using keyword in macro
77cc497
@hankbao
specify enum values
0ac32b8
@hankbao
add missing functions in iphlpapi.h
c09eb9e
@hankbao
add missing struct & SIZEOF_* functions in tcpmib
cac4b31
@hankbao
use latest defines & add SIZEOF_* functions
583f6ad
@hankbao
add missing parts and fix naming, sizing, packing issues
8186c4a
@hankbao
add tests
385fbce
@hankbao
remove comments & use DECLARE_HANDLE macro
3b5121f
@hankbao
replace all SIZEOF_* functions with FIXME comments
f0e54ba
@hankbao
fix callback return type in netioapi & iphlpapi
a5fb87c
@hankbao @retep998
Update src/shared/ifdef.rs
ed70765 
Co-Authored-By: Peter Atashian <retep998@gmail.com>
@hankbao @retep998
Update src/shared/ifdef.rs
5b4a0c0 
Co-Authored-By: Peter Atashian <retep998@gmail.com>
@hankbao @retep998
Update src/shared/ifdef.rs
33062ce 
Co-Authored-By: Peter Atashian <retep998@gmail.com>
@hankbao @retep998
Update src/shared/netioapi.rs
7a31121 
Co-Authored-By: Peter Atashian <retep998@gmail.com>
@hankbao @retep998
Update src/shared/netioapi.rs
bfc5bc1 
Co-Authored-By: Peter Atashian <retep998@gmail.com>
@hankbao @retep998
Update src/shared/nldef.rs
216da0a 
Co-Authored-By: Peter Atashian <retep998@gmail.com>
@hankbao @retep998
Update src/shared/nldef.rs
fdae58b 
Co-Authored-By: Peter Atashian <retep998@gmail.com>
@hankbao
fix field type error in MIB_IF_ROW2
66706f9
@hankbao
fix imports sorting
68e6bf2
@hankbao
fix imports
db0602d
@hankbao
have the bitfield applied directly to a Flags field in IP_ADAPTER_ADD…
2f2d3fe 
…RESSES_LH
@hankbao hankbao force-pushed the iphlpapi-support branch from d3cf184 to 2f2d3fe Compare April 7, 2020 06:49
@retep998 retep998 merged commit 57731ab into retep998:0.3 Apr 24, 2020
@dlon dlon mentioned this pull request May 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSxDOS MSxDOS MSxDOS left review comments

@TyPR124 TyPR124 TyPR124 left review comments

@retep998 retep998 Awaiting requested review from retep998

Assignees
No one assigned
Labels
waiting on review Waiting for a reviewer to review the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@hankbao @TyPR124 @ErichDonGubler @GuillaumeGomez @retep998 @vkrasnov @yuguorui @MSxDOS @BlackHoleFox