feat(req): add restifyDone event #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/api/request-events.md
Outdated
| 2) An error was returned to `next()`, and the corresponding error events have | ||
| been fired for that error type | ||
|
|
||
| The signature is for the `restifyDone` event is as follows: |
| The signature is for the `restifyDone` event is as follows: | ||
|
|
||
| ```js | ||
| function(route, error) { } |
There was a problem hiding this comment.
Any reason not to match the API of server after?
There was a problem hiding this comment.
I just thought it would look strange that we pass req in a req event...
|
|
||
| // restifyDone is emitted at the same time when server's after event is emitted, | ||
| // you can find more comprehensive testing for `after` lives in server tests. | ||
| test('should emit restifyDone event when request is fully served', function(t) { |
There was a problem hiding this comment.
Should we add a test for next(err) too?
DonutEspresso
approved these changes
Jan 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emit a
restifyDoneevent on thereqobject when the request is "fully served" (see docs in this PR).