Issue 1230/multi failuire backend regression

[irenemachine]

Fixes a few bugs around multi failure queue functionality:

Re-queueing/deleting a failed job uses the wrong index and wrong queue.
Failure overview page queue links broken.
Re-queueing/clearing all failed jobs doesn't work for all failure queues, only the failed queue.

[yaauie]

Thank you @irenemachine for diving into this. I'll try to put together some time over the weekend to try out your fixes.

[omarqureshi]

Is it worth adding some tests around requeues? I'm happy to add some

[steveklabnik]

What ended up happening with this PR? It looks like it's to another branch, not an actual release?

[omarqureshi]

I've been using it on a fork, it does look ok.

[steveklabnik]

Yeah, I guess it's the

into resque:issue-1230/multi-failuire-backend-regression

that I'm confused about. This isn't going into the actual code but some other branch?

[omarqureshi]

It's not named great for sure - but, does apply to master and doesn't need anything from that PR/issue

On 8 Jan 2016, at 17:00, Steve Klabnik notifications@github.com wrote:

Yeah, I guess it's the

into resque:issue-1230/multi-failuire-backend-regression

that I'm confused about. This isn't going into the actual code but some other branch?

—
Reply to this email directly or view it on GitHub.

[omarqureshi]

I'm not at my desk, but I think 1230 was the initial complaint of multiple failure queues not working

On 8 Jan 2016, at 17:00, Steve Klabnik notifications@github.com wrote:

Yeah, I guess it's the

into resque:issue-1230/multi-failuire-backend-regression

that I'm confused about. This isn't going into the actual code but some other branch?

—
Reply to this email directly or view it on GitHub.

[steveklabnik]

Ah, so master isn't being developed anymore, so maybe this should just be closed?

[omarqureshi]

I dunno. Having multiple failure queues is pretty useful. Is that a feature for resque 2? If not can we get it in? It's pretty important. I don't mind doing the work to get it in.

On 8 Jan 2016, at 18:49, Steve Klabnik notifications@github.com wrote:

Ah, so master isn't being developed anymore, so maybe this should just be closed?

—
Reply to this email directly or view it on GitHub.

[steveklabnik]

Resque 2 is entirely cancelled.

[omarqureshi]

Ah. Was master resque 2? This merged into whatever the working branch was for the 1.x resque.

On 8 Jan 2016, at 19:51, Steve Klabnik notifications@github.com wrote:

Resque 2 is entirely cancelled.

—
Reply to this email directly or view it on GitHub.

[steveklabnik]

Yeah, master was going to be 2, and was a total redux. So that might be the miscommunication, if this is targetted at 1-x, then it should still be good to go in some fashion.

[steveklabnik]

I'm going to merge this into that branch, and then submit a new PR with that branch to 1-x-stable. Thakns!