Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create error object in api with http code for better error management #132

Open
jschmidtnj opened this issue Aug 19, 2020 · 2 comments
Open

create error object in api with http code for better error management #132

jschmidtnj opened this issue Aug 19, 2020 · 2 comments
Assignees
@jschmidtnj
Labels
enhancement New feature or request

Comments

@jschmidtnj
Copy link
Collaborator

maybe throw apollo error or something
@jschmidtnj jschmidtnj added the enhancement New feature or request label Aug 19, 2020
@jschmidtnj jschmidtnj added this to the Version 1.0.0 milestone Aug 19, 2020
@jschmidtnj jschmidtnj self-assigned this Aug 19, 2020
@jschmidtnj
Copy link
Collaborator Author

jschmidtnj commented Aug 19, 2020 •
edited
Loading

now make sure to use ApolloError everywhere [in the api], instead of a normal Error object. define code as an http status code, so that the errors can be sorted through on the client side. eventually we will need to change all the error objects to use this paradigm

@jschmidtnj
Copy link
Collaborator Author

there are a lot of error objects that need to be updated:
image

@jschmidtnj jschmidtnj removed this from the Version 0.1.0 milestone Sep 8, 2020
@mycicle mycicle modified the milestone: Version 0.1.0 Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jschmidtnj jschmidtnj

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jschmidtnj @mycicle