Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly support / in filter queries #8903

Closed
abey79 opened this issue Feb 4, 2025 · 0 comments · Fixed by #8933
Closed

Properly support / in filter queries #8903

abey79 opened this issue Feb 4, 2025 · 0 comments · Fixed by #8933
Labels
ui concerns graphical user interface

Comments

@abey79
Copy link
Member

abey79 commented Feb 4, 2025

We discussed a plan with @Wumpf.

The plan is:

  • parse the input query into keyword as below.
  • update match logic accordingly
  • for the highlight ranges:
    • perform ranges extraction for the full hierarchy in leaf items
    • accumulate (HashSet?) match ranges in the hierarchy vector
    • merge ranges after traversing children, based on hierarchy.last()
enum Keyword {
        parts: Vec<&str>,

		/// e.g. if the query is "/a/b/c"
        first_part_must_fully_match: bool,

	    /// e.g. if the query is "a/b/c/"
        last_part_must_fully_match: bool,
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui concerns graphical user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants