Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all formatting API from ListItem and use WidgetText's API instead #4802

Open
Tracked by #6075
abey79 opened this issue Jan 15, 2024 · 1 comment
Open
Tracked by #6075
Assignees
Labels
🏎️ Quick Issue Can be fixed in a few hours or less 🚜 refactor Change the code, not the functionality ui concerns graphical user interface

Comments

@abey79
Copy link
Member

abey79 commented Jan 15, 2024

edit: thins have changed with list item 2, but this is still valid. There even is a todo about this in LabelContent.

ListItem accepts a WidgetText as input, so the formatting should happen there so that it doesn't the ListItem logic. Some helper might be needed to "prepare" the WidgetText though, e.g. to honour the re_ui::LabelStyle, etc.

@abey79 abey79 added ui concerns graphical user interface 🚜 refactor Change the code, not the functionality labels Jan 15, 2024
@abey79 abey79 added the 🏎️ Quick Issue Can be fixed in a few hours or less label Jan 15, 2024
@abey79
Copy link
Member Author

abey79 commented Jan 18, 2024

One way forward would be to implement SyntaxHighlighting for SpaceViewBlueprint, Container, etc. as a mean to produce a impl WidgetText to feed to ListItem and other re_ui helper functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏎️ Quick Issue Can be fixed in a few hours or less 🚜 refactor Change the code, not the functionality ui concerns graphical user interface
Projects
None yet
Development

No branches or pull requests

1 participant