Skip to content

Commit dfc170b

Browse files
committed
Fix python test for version check. Note on future improved version
1 parent 2f3c036 commit dfc170b

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

rerun_py/tests/unit/test_version.py

+4-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,10 @@ def test_version() -> None:
1414
if ver.prerelease:
1515
assert ver.prerelease == rr.__version_info__[3]
1616
else:
17-
assert len(rr.__version_info__) == 3
17+
# The last field is `None` if there is no prerelease.
18+
# TODO(andreas): We released `0.18.0` `"None"` as prerelease, but really it should be `None`.
19+
# assert rr.__version_info__[3] is None
20+
assert len(rr.__version_info__) == 4
1821

1922
assert rr.__version__ in rr.version()
2023

scripts/ci/update_rerun_py_and_c_version.py

+1
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ def update_python_line(line: str, version_line: str, version_info_line: str) ->
3434
def set_rerun_py_version(init_path: Path, version: semver.VersionInfo) -> None:
3535
version_line = f'__version__ = "{version}"\n'
3636
version_info_line = (
37+
# TODO(andreas): We released `0.18.0` `"None"` as prerelease, but really it should be `None`.
3738
f'__version_info__ = ({version.major}, {version.minor}, {version.patch}, "{version.prerelease}")\n'
3839
)
3940

0 commit comments

Comments
 (0)