fix: concurrent modification of processing receievd messages (googleapis#1807)

* fix: concurrent modification of processing receievd messages

* Removing synchronized keyword, and making outstandingReceipts into a concurrentMap

* Removing synchronized keyword for notifyAckSuccess and failure as well

* fixing lint

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Author: maitrimangal

google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/MessageDispatcher.java

@@ -31,7 +31,6 @@
 import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.Iterator;
-import java.util.LinkedHashMap;
 import java.util.List;
 import java.util.Map;
 import java.util.Map.Entry;
@@ -92,8 +91,8 @@ class MessageDispatcher {
   private final LinkedBlockingQueue<AckRequestData> pendingAcks = new LinkedBlockingQueue<>();
   private final LinkedBlockingQueue<AckRequestData> pendingNacks = new LinkedBlockingQueue<>();
   private final LinkedBlockingQueue<AckRequestData> pendingReceipts = new LinkedBlockingQueue<>();
-  private final LinkedHashMap<String, ReceiptCompleteData> outstandingReceipts =
-      new LinkedHashMap<String, ReceiptCompleteData>();
+  private final ConcurrentMap<String, ReceiptCompleteData> outstandingReceipts =
+      new ConcurrentHashMap<String, ReceiptCompleteData>();
   private final AtomicInteger messageDeadlineSeconds = new AtomicInteger();
   private final AtomicBoolean extendDeadline = new AtomicBoolean(true);
   private final Lock jobLock;
@@ -411,7 +410,7 @@ void processReceivedMessages(List<ReceivedMessage> messages) {
     processBatch(outstandingBatch);
   }
 
-  synchronized void notifyAckSuccess(AckRequestData ackRequestData) {
+  void notifyAckSuccess(AckRequestData ackRequestData) {
 
     if (outstandingReceipts.containsKey(ackRequestData.getAckId())) {
       outstandingReceipts.get(ackRequestData.getAckId()).notifyReceiptComplete();
@@ -437,7 +436,7 @@ synchronized void notifyAckSuccess(AckRequestData ackRequestData) {
     }
   }
 
-  synchronized void notifyAckFailed(AckRequestData ackRequestData) {
+  void notifyAckFailed(AckRequestData ackRequestData) {
     outstandingReceipts.remove(ackRequestData.getAckId());
   }