Skip to content

Commit 2990c95

Browse files
committed
test(hmr): fix windows cli access
1 parent c3ed2de commit 2990c95

File tree

2 files changed

+25
-22
lines changed

2 files changed

+25
-22
lines changed

integration/helpers/create-fixture.ts

+19-19
Original file line numberDiff line numberDiff line change
@@ -223,25 +223,25 @@ export async function createFixtureProject(
223223
path.join(projectDir, "node_modules"),
224224
{ overwrite: true }
225225
);
226-
let remixDev = path.join(
227-
projectDir,
228-
"node_modules/@remix-run/dev/dist/cli.js"
229-
);
230-
await fse.chmod(remixDev, 0o755);
231-
await fse.ensureSymlink(
232-
remixDev,
233-
path.join(projectDir, "node_modules/.bin/remix")
234-
);
235-
236-
let remixServe = path.join(
237-
projectDir,
238-
"node_modules/@remix-run/serve/dist/cli.js"
239-
);
240-
await fse.chmod(remixServe, 0o755);
241-
await fse.ensureSymlink(
242-
remixServe,
243-
path.join(projectDir, "node_modules/.bin/remix-serve")
244-
);
226+
// let remixDev = path.join(
227+
// projectDir,
228+
// "node_modules/@remix-run/dev/dist/cli.js"
229+
// );
230+
// await fse.chmod(remixDev, 0o755);
231+
// await fse.ensureSymlink(
232+
// remixDev,
233+
// path.join(projectDir, "node_modules/.bin/remix")
234+
// );
235+
//
236+
// let remixServe = path.join(
237+
// projectDir,
238+
// "node_modules/@remix-run/serve/dist/cli.js"
239+
// );
240+
// await fse.chmod(remixServe, 0o755);
241+
// await fse.ensureSymlink(
242+
// remixServe,
243+
// path.join(projectDir, "node_modules/.bin/remix-serve")
244+
// );
245245

246246
await writeTestFiles(init, projectDir);
247247

integration/hmr-test.ts

+6-3
Original file line numberDiff line numberDiff line change
@@ -247,12 +247,15 @@ let customServer = (options: { appPort: number; devReady: string }) => {
247247

248248
let HMR_TIMEOUT_MS = 30_000;
249249

250+
let remix = "node ./node_modules/@remix-run/dev/dist/cli.js";
251+
let serve = "node ./node_modules/@remix-run/serve/dist/cli.js";
252+
250253
test("HMR for remix-serve", async ({ page }) => {
251254
await dev(page, {
252255
files: (appPort) => ({
253256
...files,
254257
"package.json": packageJson({
255-
devScript: `cross-env PORT=${appPort} remix dev`,
258+
devScript: `cross-env PORT=${appPort} ${remix} dev -c "${serve} ./build/index.js"`,
256259
deps: ["@remix-run/serve"],
257260
}),
258261
}),
@@ -265,7 +268,7 @@ test("HMR for custom server with broadcast", async ({ page }) => {
265268
files: (appPort) => ({
266269
...files,
267270
"package.json": packageJson({
268-
devScript: `remix dev -c "node ./server.js"`,
271+
devScript: `${remix} dev -c "node ./server.js"`,
269272
deps: ["@remix-run/express"],
270273
}),
271274
"server.js": customServer({
@@ -282,7 +285,7 @@ test("HMR for custom server with log", async ({ page }) => {
282285
files: (appPort) => ({
283286
...files,
284287
"package.json": packageJson({
285-
devScript: `remix dev -c "node ./server.js"`,
288+
devScript: `${remix} dev -c "node ./server.js"`,
286289
deps: ["@remix-run/express"],
287290
}),
288291
"server.js": customServer({

0 commit comments

Comments
 (0)